@tus/server: set CORS headers before early returns - #873
Merged
Conversation
Move Access-Control-* setup above the 412 Tus-Resumable check and header-validation 400s so browsers can read those responses. Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
🦋 Changeset detectedLatest commit: 0878249 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
@Murderlon what do you think about this change? |
Murderlon
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
Access-Control-*block above the 412Tus-Resumablecheck and the header-validation 400s. Those returns currently happen before CORS is set, so a browser sees a network/CORS failure instead of the real status.GET still dispatches earlier and stays CORS-less (pre-existing).
Test plan
Tus-Resumable) and validation 400 both includeAccess-Control-Allow-Originfor a matching origin, plus credentials and expose-headers@tus/server