Restore HubDNS packaging and preserve published records - #7
Open
lirazsiri wants to merge 3 commits into
Open
Conversation
Correct the dh_link source and destination order and restore the historical hubdns command names consumed by inithooks, cron, and the systemd service. The v1.4 package had replaced its Python command modules with dangling links to nonexistent hub-* binaries, which prevented Hub DNS initialization on every v19 appliance. Verified by building an unsigned Trixie package, extracting it, compiling all four command modules, and resolving each installed command symlink to its packaged module.
Import the installed py3curl-wrapper module and expose its current APIError class. HubDNS 1.4 depended on the Python 3 package but still imported the removed Python 2 module and exception name, so every command failed before contacting the Hub. Verified by installing the rebuilt package on the live Hub-launched WordPress v19 instance, initializing its tklapp.com record, updating the address, and reading the registered address back successfully.
The one-shot systemd unit declared an ExecStop release action without remaining active after ExecStart. Systemd therefore released each DNS record immediately after a successful update, sending Hub hostnames back to the wildcard address and presenting the Hub certificate instead of the appliance certificate. Keep the unit active after its update so release runs only during a real stop or shutdown. Verified with the focused service-unit test and systemd-analyze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the executable entry points for the Python 3 port and keeps the one-shot systemd service active after publishing its record. Without RemainAfterExit, systemd immediately ran hubdns-release and removed the exact tklapp.com record, leaving clients on the wildcard Hub endpoint.
Verification: focused package tests pass, systemd-analyze verifies the installed unit, and a live v19 WordPress instance retained its exact Route53 record and valid Let’s Encrypt endpoint across reboot.