[pull] master from ruby:master - #1262
Merged
Merged
Conversation
So code in documentation are tested.
This global cache was unsynchronized and across Ractors that is racy and leads to undefined behavior. The repro code included as a regression test was crashing with SEGV or producing bad results from bignum#to_s before this fix.
#17467) A monomorphic-specialized call site (warmed up with class A) must still return correct results when a second class B with its own ISEQ method of the same name flows through it. The receiver type guard should send the B receiver to the side exit rather than dispatching to A#foo. This side-exit-on-unexpected-class behavior was not covered by an existing test. Distinct return values (1 vs 2) make a broken guard observable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )