[pull] master from php:master - #1135
Merged
Merged
Conversation
This prevents a reallocation
As this is the expected type for lineno everywhere else in the engine
This remove a strlen() computation.
While at it clarify path concatenation code by using the zend_string_concat{2|3} APIs rather than a memcpy and strncpy calls
Allows us to convert a strcmp() call to zend_string_equals_literal() which is less confusing
This prevents a reallocation
Instead of the old way of logging errors and displaying them use the new APIs.
shm is mandatory for preloading.
This should never happen in the first place
php_json_encode_array() reads a hooked property into a local zval and bails out when an exception is pending. The get hook can publish its return value into that zval and then throw while its frame is freed, for example from the destructor of one of its locals, so the bailout leaks the value until request shutdown. Destroy it on the way out, the way the other failure exit already does. Closes GH-22919
* PHP-8.4: Free the hooked property value when json_encode() sees an exception
No need to duplicate the logic
Prevents some reallocations and strlen() recomputations
* PHP-8.5: Free the hooked property value when json_encode() sees an exception
Avoids creating 70,000 files on platforms unaffected by the Win32 DIR_W32.offset regression. Shaves ~9s off non-Windows test runs.
* Clean up IPC objects in arginfo mismatch test * Fix GH-16592 test leaking a message queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )