Skip to content

fix(linux): prevent tasks from appearing under the wrong list after view switch #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turinglambdaai merged 3 commits into from
Oct 21, 2026
Merged

fix(linux): prevent tasks from appearing under the wrong list after view switch #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
335100d
fix(linux): reject stale view replies and restore named-list snapshot…
turinglambdaai Oct 20, 2026
d4deea8
docs: require view-scoped snapshots across list switching and databas…
turinglambdaai Oct 20, 2026
5460853
docs: rely on integrated snapshot scope contract
Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions linux/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,14 +955,25 @@ void reload_snapshot() {
? std::optional<std::int64_t>(list_id)
: std::nullopt,
include_completed,
[](rivet_app::Result<rivet_app::Snapshot> result) {
[view_kind, list_id, include_completed](
rivet_app::Result<rivet_app::Snapshot> result) {
// Release the reload gate on every terminal path so later polls and
// `changed` events are not swallowed.
dispatch_ui([] {
g_state.reload_in_flight.store(false, std::memory_order_release);
});
on_result(std::move(result),
[](rivet_app::Snapshot const& snapshot) {
[view_kind, list_id, include_completed](
rivet_app::Snapshot const& snapshot) {
// Lists can change during an asynchronous RPC. Never
// paint an outdated Work snapshot under a Life heading.
// Reload with the new view after the in-flight gate clears.
if (g_state.view != view_kind ||
g_state.view_list_id != list_id ||
g_state.show_completed != include_completed) {
reload_snapshot();
return;
}
g_state.current_counts = snapshot.counts;
g_state.lists = snapshot.lists;
g_state.tasks = snapshot.tasks;
Expand Down Expand Up @@ -3056,7 +3067,16 @@ void open_database_at(std::string const& path) {
g_state.view_list_id = 0;
}
rebuild_sidebar();
rebuild_task_list();
if (g_state.view == ViewKind::List) {
// open_database returns an ALL-view snapshot. Wait for
// the authoritative selected-list query before showing
// rows under the restored named list's heading.
g_state.tasks.clear();
rebuild_task_list();
reload_snapshot();
} else {
rebuild_task_list();
}
refresh_persistent_status();
// Reminders: a different database resets the per-session
// dedupe set; every open runs the startup check.
Expand Down
Loading