Repository navigation
Add the sibling-asset helper and the sign-manifest subcommand - #266
Merged
Merged
Conversation
Three products hand-roll the same sibling-asset download and all three copies skip the HTTP status check, so a 404 page was saved as the payload and only failed later with a misleading checksum error. The shared fetch-sibling-asset fails fast on non-2xx statuses, enforces the declared Content-Length against the byte limit, verifies an optional expected SHA-256, and streams under the same deadlines as the manifest fetch. Two private signed-feed assembly paths (bash+OpenSSL and Racket) collapse into raco rivet sign-manifest: it builds the manifest from explicitly named artifacts, signs through the distribution signer, verifies the written bytes with the public half before publishing and deletes the output when verification fails, and optionally emits .sha256 sidecars. Products keep only their asset-naming conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250 and #243.
fetch-sibling-asset (rivet/distribution): every private copy skipped the HTTP status check, so a 404 page was saved as the payload and failed later with a misleading checksum error. The shared helper fails fast on non-2xx, enforces the declared Content-Length against the byte limit, verifies an optional expected SHA-256, and streams under the same connect/idle deadlines as the manifest fetch (#263).
raco rivet sign-manifest: the two private signed-feed assembly paths (taskly's bash+OpenSSL, fulcrum's Racket) collapse into one subcommand that builds the manifest from explicitly named artifacts, signs through the distribution signer, verifies the written bytes with the public half before publishing (deleting the output on failure), and optionally emits .sha256 sidecars. Products keep only their asset-naming conventions.