Repository navigation
Centralize distribution target identity helpers - #258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Products currently copy Rivet’s manifest platform and architecture mapping, installer filename extensions, and RFC 3339 timestamp formatting. This adds a leaf-loadable
rivet/distribution/identitymodule, re-exports it fromrivet/distribution, and makes the release path, platform adapter, and managed updater consume the shared implementation. Unknown platforms, architectures, and installer kinds now fail closed; release timestamps are always formatted from UTC rather than labeling local time withZ.The managed updater also uses the canonical extension map, so
targzandappimagedownloads receive.tar.gzand.AppImagefilenames.Closes #239.
Validation:
PLTCOLLECTS="$PWD:" raco test rivet/tests/— 9,729 tests passed; public API and documentation checks rerun after the final edit — 636 tests passed.