Conversation
Use CircuitJsonToKicadProConverter in generateKicadProject instead of a minimal stub scaffold so that board design-rule limits and net classes are preserved in index.kicad_pro. Also explicitly map min_board_edge_clearance to min_copper_edge_clearance in both build and snippet export paths. Fixes tscircuit#4716
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When building with
tsci build --kicad-projector--kicad-project-zip, the generatedindex.kicad_propreviously used a minimal stub scaffold that omittedboard.design_settings.rulesandnet_settings. Explicit board design limits such asmin_trace_widthandmin_board_edge_clearancewere dropped, causing native KiCad DRC to evaluate clearances against KiCad fallback defaults instead of the declared project limits.Changes
createKicadProContentincli/build/generate-kicad-project.tswithCircuitJsonToKicadProConverter(matching the pattern used in snippet export).pcbBoard.min_board_edge_clearanceintoboard.design_settings.rules.min_copper_edge_clearancein bothgenerate-kicad-project.tsandexport-snippet.ts.tests/cli/build/build-kicad-project-rules.test.tsverifying thatmin_track_width,min_copper_edge_clearance, and net class rules are preserved during export.Fixes #4716
/claim #4716