Repository navigation
Don't crash when settings open before Backtalk has connected - #226
Merged
aryanchoudharypro merged 2 commits intoOct 20, 2026
Merged
Conversation
Opening Backtalk's settings just after it was updated or restarted could crash it. The settings screen asks the service for its exit watermark controller as it opens, and the service made one from its pipeline, which doesn't exist until the service is connected. The service now has no exit watermark controller until it is connected, and its callers already handle that. - Unit test for the controller before the service is connected.
mad-gamer26
added a commit
to mad-gamer26/BacktalkRemote
that referenced
this pull request
Oct 20, 2026
Brings in the keyboard-safe text fields (trypsynth#225), which also cover the remote access key and relay server dialogs through the replaced EditTextPreference layout, settings that open before Backtalk has connected (trypsynth#226), and the fresh reading order search (trypsynth#221). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKArzG82mfYh483GfqQKFo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Backtalk's settings just after Backtalk is updated or restarted could crash it with a NullPointerException:
TalkBackService.getInstance()returns the service fromonCreate, but the service's pipeline is only made inonServiceConnected. The settings screen can resume in between.getTalkBackExitControllerthen made the controller from the null pipeline.getTalkBackExitControllernow returns null until the service is connected.TalkBackPreferenceFragmentandListMenuManageralready handle null.reloadPreferencesnow does too.Tested: