Repository navigation
Allow silencing events in sound themes, add accessibility actions, and add screen on sound - #224
Merged
Conversation
… and screen on sound
… name the constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to silence specific sound events in sound themes (both in settings and via
theme.json), adds custom accessibility actions to the theme sound customization screen, and introduces ascreen_onsound event that defaults to silent in Backtalk.What was changed
1. Silencing sound events ("No sound")
theme.json, sound themes can now silence events by declaring:2. Custom accessibility actions in theme sounds
3. Screen on event
screen_onas an individual feedback sound event (in Individual sounds and vibrations and in theme Sounds).screen_onplays no sound in Backtalk (same behavior as before).4. Tests and Documentation
SoundThemeManifestTest,SoundThemesTest, andThemeFeedbackTest.themes.mddocumenting"sounds"intheme.jsonand thescreen_onevent.Testing
./gradlew :talkback:testPhoneDebugUnitTest :utils:testPhoneDebugUnitTest.