Fix OpenRouter via laravel/ai default provider (revises #216) - #220
Closed
paulocastellano wants to merge 1 commit into
Closed
Fix OpenRouter via laravel/ai default provider (revises #216)#220paulocastellano wants to merge 1 commit into
paulocastellano wants to merge 1 commit into
Conversation
PR #216 patched Lab::OpenRouter into every agent match, but laravel/ai already resolves config('ai.default') — including openrouter — when agents omit provider(). Those matches also forced unknown providers to Gemini and BrandAnalyzerRunner checked a non-existent services.openrouter key. Remove the duplicated provider() overrides, gate availability on ai.providers.*.key, and document OPENROUTER_API_KEY. Co-authored-by: Paulo Castellano <hello@paulocastellano.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes / revises #216.
Why
#216 added
'openrouter' => Lab::OpenRouterto every agentprovider()match. That works on the surface, but:Lab::OpenRouter,createOpenrouterDriver,config/ai.phpprovider entry). When an agent omitsprovider(),Promptablefalls back toconfig('ai.default').openai/anthropicwas forced to Gemini, soAI_TEXT_PROVIDER=openrouternever reached OpenRouter.BrandAnalyzerRunnercheck usedconfig('services.openrouter.api_key'), which does not exist — so brand autofill would still treat OpenRouter as unavailable.As noted in #216, the better fix is to stop hardcoding provider maps in every agent.
What changed
provider()from all AI agents so they useconfig('ai.default')(supportsopenrouter,openai,anthropic,gemini, etc.).App\Support\AiConfiguration::isTextProviderConfigured()readingai.providers.{default}.key.BrandAnalyzerRunner::isAvailable()and sharedaiEnabledthrough that helper.OPENROUTER_API_KEY/openrouterin.env.example.provider().Setup for OpenRouter
Closes #216 once merged (or we can close #216 manually in favor of this).