Skip to content

fix: SetFunctionName always includes prefix - #993

Merged
aapoalas merged 1 commit into
trynova:mainfrom
DonIsaac:don/fix/class-get-set-name
Oct 18, 2026
Merged

aapoalas merged 1 commit into
trynova:mainfrom
DonIsaac:don/fix/class-get-set-name

Conversation

@DonIsaac

@DonIsaac DonIsaac commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What This PR Does

Fixes a bug in SetFunctionName where symbol names for getters and setters omitted "get " and "set " prefixes when description was None.

Fixes 5 Test262 cases.

@DonIsaac DonIsaac changed the title fix: SetFunctionName always includes prefix fix: SetFunctionName always includes prefix Sep 6, 2026
@DonIsaac

DonIsaac commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Spellcheck and Clippy appear to be failing in unrelated files.

@DonIsaac
DonIsaac marked this pull request as ready for review September 6, 2026 20:49
aapoalas
aapoalas previously approved these changes Sep 9, 2026

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you <3

@aapoalas
aapoalas force-pushed the don/fix/class-get-set-name branch from 031207d to 456a996 Compare October 18, 2026 09:58
@aapoalas
aapoalas merged commit 877ef16 into trynova:main Oct 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants