Repository navigation
ci: build the example app for iOS Simulator on PRs - #72
Merged
Merged
Conversation
Nothing in CI compiled the Swift bridge in ios/, so the Courier_iOS 5.9.0 bump (#68) went green while putUserToken no longer compiled. The new build-ios job runs on macos-15, resolves Courier_iOS from the podspec pin, and builds example-085 for the iOS Simulator with signing disabled. The example Podfile also pinned Courier_iOS to git tag 5.8.3, which overrode the podspec pin; drop it so the build uses the pinned version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mikemilla
force-pushed
the
ci/ios-simulator-build
branch
from
October 1, 2026 19:25
2d3047f to
fdec988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
No CI job compiled the Swift bridge in
ios/. The Courier_iOS 5.8.6 → 5.9.0 bump (#68) went green, butcourierDevice ?? CourierDevice()inputUserTokenstopped compiling, because 5.9.0 made the zero-argCourierDevice()init@MainActor. The fix had to be made by hand.What
build-iosjob (macos-15, Xcode 16.4, the same toolchain as courier-ios CI). It runsbundle exec pod update Courier_iOSinexample-085/ios, checks that the resolved Courier_iOS matches thecourier-react-native.podspecpin, then builds the example withxcodebuild -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO.pod update Courier_iOSrather thanpod installbecause bump PRs (bump-courier-ios-*) change the podspec without touchingPodfile.lock.Env.tsxisn't needed.concurrencycancels superseded runs to save macOS minutes.pod 'Courier_iOS', :git => …, :tag => '5.8.3'. It overrode the podspec pin, so the example never built against the version the library ships with. RefreshedPodfile.lock(now 5.8.6 from trunk).Testing
build-iosrun is the first real check.call to main actor-isolated initializer … in a synchronous nonisolated context, which is the error this job is meant to catch.🤖 Generated with Claude Code