Skip to content

feat(stats): show total rules downloads on the badge - #229

Merged
sairenchristianbuerano merged 1 commit into
mainfrom
feat/badge-total-downloads
Nov 9, 2026
Merged

sairenchristianbuerano merged 1 commit into
mainfrom
feat/badge-total-downloads

Conversation

@sairenchristianbuerano

Copy link
Copy Markdown
Collaborator

The README downloads badge now shows the total rules downloads (bundle pulls + statement.json fetches, including the counts carried over from replaced files), instead of bundle pulls only. badges/downloads.json is set to the 10 Nov total, 6,511, so the badge matches download-history.json now; the weekly snapshot keeps it current.

Also corrects the snapshot PR description: statement.json is fetched on every online scan (releasesource.go), not cached for 30 days; 30 days is how long a statement stays valid.

Note: a scan with no cached bundle fetches both files, so the total counts it twice. The bundle / statement split stays in the series.

The downloads badge showed bundle pulls only. It now shows the snapshot's
total (bundle pulls plus statement.json fetches, including the counts
publish.yml carries over from replaced files), and badges/downloads.json
is set to the latest point's total (6,511 on 10 Nov). The split stays in
download-history.json.

Also corrects the snapshot PR text: statement.json is fetched on every
online scan, not cached for 30 days.

@trustabl trustabl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@sairenchristianbuerano
sairenchristianbuerano merged commit 78a7e75 into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants