Repository navigation
feat(stats): show total rules downloads on the badge - #229
Merged
Merged
Conversation
The downloads badge showed bundle pulls only. It now shows the snapshot's total (bundle pulls plus statement.json fetches, including the counts publish.yml carries over from replaced files), and badges/downloads.json is set to the latest point's total (6,511 on 10 Nov). The split stays in download-history.json. Also corrects the snapshot PR text: statement.json is fetched on every online scan, not cached for 30 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README downloads badge now shows the total rules downloads (bundle pulls + statement.json fetches, including the counts carried over from replaced files), instead of bundle pulls only.
badges/downloads.jsonis set to the 10 Nov total, 6,511, so the badge matchesdownload-history.jsonnow; the weekly snapshot keeps it current.Also corrects the snapshot PR description: statement.json is fetched on every online scan (
releasesource.go), not cached for 30 days; 30 days is how long a statement stays valid.Note: a scan with no cached bundle fetches both files, so the total counts it twice. The bundle / statement split stays in the series.