Skip to content

fix(rules): narrow AGCFG-006 endpoint keys and add env, sed and awk to AGCFG-012 - #301

Open
ivanpaghubasan wants to merge 1 commit into
mainfrom
fix/agcfg-006-012
Open

ivanpaghubasan wants to merge 1 commit into
mainfrom
fix/agcfg-006-012

Conversation

@ivanpaghubasan

@ivanpaghubasan ivanpaghubasan commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

No schema change (stays 41). Can merge independently of the schema 42–45 PRs.

Summary

Maintenance on two live agent_config rules, based on findings while building batch 1.

AGCFG-006 (critical, unchanged):

  • Codex: a project-local .codex/config.toml no longer flags endpoint keys. The Codex configuration reference and PROJECT_LOCAL_CONFIG_DENYLIST in the Codex loader both say a project file ignores openai_base_url, chatgpt_base_url, model_provider, model_providers and profiles, so flagging them was a false positive.
  • Gemini: .gemini/.env flags only GOOGLE_GEMINI_BASE_URL and GOOGLE_VERTEX_BASE_URL, the two endpoint variables Gemini CLI reads (contentGenerator.ts). It no longer flags OPENAI_BASE_URL, ANTHROPIC_BASE_URL or any other *_BASE_URL, which Gemini CLI does not read.
  • The explanation now states that Gemini CLI loads the full .env only in a trusted workspace, and Codex loads project config only when the project is trusted.
  • Key names only, as before; values are not read.

AGCFG-012 (medium, unchanged):

  • Adds env, sed and awk. The GNU manuals show env runs its command operand, sed runs a program through its e command or the s///e flag, and awk runs one through system() or a pipe. The Claude Code permissions page documents no prompt for these forms under a prefix rule (unlike find, which stays out).

Verification

  • go build, go vet, go test ./... pass; check-rules-sync.sh in sync; 389 rules at schema 41.
  • Corpus before/after: no finding changed in any of the 34 corpus dirs.
  • 120 public .codex/config.toml files: no finding changed.
  • A planted fake value in the tests never appears in facts, reasons or JSON.

Not verified

  • .gemini/.env files in public repos could not be sampled (no search access).
  • Whether Claude Code prompts for some env, sed or awk forms in ways its docs do not describe.

Follow-up

Verify which tool reads _PROXY_COMMAND and GEMINI_SANDBOX keys in a Codex config.toml; they are kept for now.

Related

Rules: trustabl/agent-reliability-rules#232
Rulebook: trustabl/trustabl-rulebook#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants