Repository navigation
test(websocket): skip the room retry tests on the shared listen fd (#329) - #330
Merged
Merged
Conversation
) They need a subscriber on every worker, which #240 does not promise and the shared fd measurably does not give: 065 failed there on 2 to 5 runs of 20. The retry queue stays covered by the first CI pass.
Contributor
CoverageTotal lines: 83.67% → 83.66% (-0.02 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
websocket/064–066test the cross-worker retry queue and need a subscriber on each of two workers. The server does not promise which worker accepts (#240), and on the shared listen fd — the second pass ofLINUX_X64_DEBUG_ZTS— it measurably does not spread:065/066failed there three times in two runs of #328, and locally065readno subscriber on a remote workeron 3 of 10, 5 of 20 and 2 of 20 runs, against 0 of 16 on SO_REUSEPORT. The measurements of the skew are in #329; its cause is not traced.The three tests now skip on the shared fd, through
_ws_spread_skipif.inc, which mirrorscore/076's condition. The retry queue reads nothing about the listener and stays covered by the first pass. Decided with Edmond; the helper and the workflow are unchanged.dev/PLAN.md: the decision with its numbers, and an open item found on the way —http_server_pause_listenersmay not stop accepting on the socket, to be reproduced first.Verified
With the hooks build of
main:TRUE_ASYNC_SERVER_SHARED_LISTEN_FD=1skips all three with the reason; without it each passes 10 of 10.