Repository navigation
asynctest: a stream write refused at submit marks the handle failed (true-async/php-async#315) - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight cmocka cases for true-async/php-async#315. A fire-and-forget write refused at submit must set
ZEND_ASYNC_IO_WRITE_FAILEDon the handle before itsfree_cbruns, hand the buffer back once and leave an exception:uv_writerefuses at once (a read-only pipe);The comment on
ZEND_ASYNC_IO_WRITE_FAILEDinZend/zend_async_API.hnow says it covers refusals and stream handles only; no ABI change.7 of 8 fail against php-async
main(c95dcf7), 8 of 8 pass against php#315, 3 runs; under valgrind the test loses nothing and leaves no descriptor open. Built with--enable-asynctest; no CI job runs this SAPI.