Repository navigation
Fix Context cycle collection and GC ownership - #312
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexts that retain themselves as a value or object key cannot be collected because Context does not expose its internal references to Zend GC. Coroutine and Scope also expose the context's contents instead of their owned reference to the Context object.
Add Context's GC handler, enumerate the actual Context ownership edges from Coroutine and Scope, and release the context tables in free_obj so they remain valid during GC's traversal after destructors.
The regression test checks automatic collection of standalone value/key cycles and collection of contexts owned by completed coroutines and disposed scopes.
Validation: 94 Context/Scope/GC PHPT passed with four workers on PHP 8.6.0-dev, ZTS debug, TrueAsync ABI 0.26.0. git diff --check passed.