Repository navigation
Correct what the TransmitFile comments say about EOF and the socket mode - #309
Merged
Merged
Conversation
A probe on Windows 11: a count or start past EOF fails with WSAEINVAL rather than stopping at EOF, and libuv's socket is non-blocking (FIONBIO); the call is still synchronous with a NULL OVERLAPPED.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only, in
io_transmitfile_work_cb.A probe of synchronous TransmitFile on Windows 11 26200 (NULL OVERLAPPED; a blocking socket and one set up as libuv's
uv__tcp_set_socketdoes, same results):The clamp from 1521d69 stays; the code is unchanged. Recorded in true-async/server
dev/DECISIONS.md(PR true-async/server#369).