[chikamura]

Summary

Follow-up to #126, addressing the non-blocking suggestions in its review (#126 (review)). #126 itself stays at the approved commit; this PR is stacked on it and carries only the changes below. Test code only.

• The cursor, not a count assertion, reports a diverging run. runWithMockServer() compared the request count to the response count before the test could walk a single request, so a step that gained or lost a call failed with a bare expected:<10> but was:<9> and the cursor never got to say where. The count check is gone: the cursor is handed every recorded request, a run that made fewer calls fails at the first next() with nothing left, and one that made more fails when the cursor is closed, whose message now lists the unasserted requests as GET /path (the 599 fail-fast answer usually fails the action before that). The harness self-tests cover both directions.
• Completeness no longer depends on remembering a final call. RequestCursor is AutoCloseable and close() checks that every request was walked, so tests hold the cursor in a try-with-resources; the explicit assertNoMore() calls are gone. A failure in the try body still wins: the close() failure is attached to it as suppressed. The two harness self-tests for a run that made too many or too few requests keep the cursor outside a try on purpose, since they assert on the failure itself.
• assertLoadAttempt() returns both upload requests. It returns a LoadAttempt holding the session-open POST and the file PUT, so testRunAppendDirectMode and its no-compression twin use it instead of re-implementing it inline, and a change to what one attempt consists of ([ruby-compat/07] Fail fast instead of swallowing data-loss errors #123) lands in one place. Callers that only want the POST read .openUpload off the result.
• next() says which request the test asserts. The failure message read "after 9 ... only 9" (position printed twice); it now says "the test asserts request Retry for bq transfer #10 but the run recorded only 9", counting from 1 like the test's response list.
• The re-wrapped runWithMockServer() comment no longer has a short line; it was rewritten with the first item.

Test plan

• ./gradlew test (158 tests, 1 skipped)
• ./gradlew spotlessApply

🤖 Generated with Claude Code

[john-abre]

Approve します。#126 で挙げた非ブロッキングの 6 点がすべて反映されています。
assertNoMore() の呼び出しは残っておらず、try-with-resources の外でカーソルを持つのは、失敗自体を検証するハーネスのセルフテスト 2 件だけであることを確認しました。
挙動も問題ありません: try 本体の失敗が優先されて close() の失敗は suppressed として付き、リクエストが少ない run は最初の next() で、多い run は close() が余分なリクエストを名指しして失敗します。セルフテストが両方向をカバーしています。
手元でも ./gradlew spotlessCheck test を実行し、158 テスト（1 skip）がすべて通りました。

🤖 Generated with Claude Code