[chikamura]

Summary

Re-submission of #125 together with its follow-up #127. Both were squash-merged before the review on #125 (#125 (review)) had been addressed and approved, so feature/ruby-compatibility has been reset to its pre-#125 state and the same content is put back under review here. The tree is identical to what #127 left on the branch; the commits are the original ones from #125 followed by the five review fixes.

The change (from #125)

google-cloud-bigquery 2.14.0 hardcodes the googleapis.com host for the request that opens a resumable upload session (HttpBigQueryRpc#open()), so BigqueryClient#load() used to take a test-only jobs.insert path under test_host, leaving the actual upload code untested.

• TestHostBigQueryRpc, an HttpBigQueryRpc subclass installed through the test_host BigQueryOptions, builds that one URL from the configured host (what upstream does since fix: custom host for resumable uploads googleapis/java-bigquery#2696); the jobs.insert bypass is gone. The two test-host classes move to their own package (testhost.TestHostBigQueryOptions / TestHostBigQueryRpc).
• The MockWebServer tests now see the real session-open POST and file PUT and assert on the uploaded bytes. loadAttemptResponses() / assertLoadAttempt() describe one load attempt (open, PUT, jobs.get) so retry scenarios list attempts instead of individual responses.
• New helpers and tests for upload failures: connection reset and 5xx during a chunk PUT (re-sent by the library on the same session, retries times), 4xx (not re-sent), the read timeout applying to the PUT, and a file over the chunk size going up as several PUTs.
• Mock requests with no enqueued response are answered right away with a 599 instead of blocking until the client's read timeout, and the test HTTP timeouts are short.

Review fixes (from #127)

• Request bodies can be read more than once: readRequestBodyAsString() and uploadedLines() read getBody().clone() instead of draining the RecordedRequest's Buffer; a harness self-test pins it.
• One source for the mock server's origin (testHostOf()), used for both test_host and the resumable upload's Location.
• The harness self-test matches on runWithMockServer()'s own message instead of JUnit's wording.
• TestHostBigQueryRpc records why it is tied to 2.14.0, that the upstream fix ships in 2.26.1, and that the testhost seam goes away once the library is upgraded.
• Comments put back where spotless leaves them alone, and the load-attempt retry note moved to the test it describes.

The remaining review premise, that #123 covers both the swallowed upload exception and the channel close() finalizing a partial file, is handled in #123 itself.

#126 (request cursor) is stacked on this branch; its base will move back to feature/ruby-compatibility once this is merged.

Test plan

• ./gradlew test (157 tests, 1 skipped)
• ./gradlew spotlessApply

🤖 Generated with Claude Code

[john-abre]

Approve します。#127 のマージコミット (6301893) と tree が完全に一致していることを確認しました。
#125 で挙げた 5 点はすべて反映されています: ボディのヘルパーが記録済み Buffer の clone を読む（セルフテストで固定）、モックサーバーの origin が testHostOf() に一本化、ハーネスのセルフテストがハーネス自身のメッセージにマッチ、TestHostBigQueryRpc にバージョン固定の理由と削除条件を記載、コメントが spotless に動かされない位置に配置。
approve の前提にしていた load() のアップロード例外の握りつぶしと部分ファイルの close は、#123 の説明で明示的に対象になっているので解消です。
手元でも ./gradlew spotlessCheck test を実行し、157 テスト（1 skip）がすべて通りました。

🤖 Generated with Claude Code