Repository navigation
Conversation
First run against a fresh dataset: the destination table doesn't exist, so autoCreate()'s tables.delete gets a 404. The client library maps that to BigQuery#delete() returning false, and the plugin ignores the return value, so the run proceeds exactly as when the delete succeeds. Pin that down with a mock-server run that returns 404 on the initial delete. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2 tasks done
chikamura
self-requested a review
September 25, 2026 03:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #110. Adds one end-to-end test,
testRunDeleteInAdvanceModeWhenDestinationTableDoesNotExist, covering the first run ofmode: delete_in_advanceagainst a fresh dataset, where the destination table does not exist yet.Every mock response in the current suite is either a success or a 500. This is the first 404 case. It pins down that:
autoCreate()'stables.deletereceives a 404BigQuery#delete()returningfalserather than throwingWRITE_TRUNCATE, temp table delete, finalgetTableThe test is a copy of
testRunDeleteInAdvanceModewith the second enqueued response swapped forerrorResponse(404, ..., "notFound"). All request-sequence assertions are identical to the success case, which is the point.Test plan
./gradlew spotlessApply test --tests TestBigqueryJavaOutputPluginWithMockServerpasses (9 tests, including the new one)🤖 Generated with Claude Code