Repository navigation
Conversation
Normalize source_format (with JSONL alias) and compression values and reject anything outside BigQuery's supported set, matching ruby's configure(). Also wire validateTimePartitioning into validate(), which was previously defined but never invoked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
getProjectIdFromJsonKeyfile() used JSONObject#getString, which throws JSONException instead of returning null when project_id is missing, making the intended ConfigException unreachable. Switch to optString so the existing null check works as intended. Also add tests covering the auth_method/json_keyfile/ workload_identity_federation/project checks ported from ruby's configure(), which previously had no coverage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
chikamura
changed the base branch from
master
to
feature/ruby-compatibility
September 25, 2026 03:38
chikamura
marked this pull request as ready for review
September 29, 2026 01:21
chikamura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure()validatessource_format/compression(normalizing case, acceptingJSONLas an alias forNEWLINE_DELIMITED_JSON) and rejects anything else. Java had no such validation. AddvalidateSourceFormat/validateCompressiontoBigqueryConfigValidator.validateTimePartitioningwas defined but never wired intovalidate(); fix that dead-code bug.BigqueryClient#getProjectIdFromJsonKeyfile(): it usedJSONObject#getString, which throwsJSONExceptioninstead of returningnullwhenproject_idis missing, making the intendedConfigExceptionunreachable. Switch to
optStringso the existing null check works as intended.AuthTestcovering theauth_method/json_keyfile/workload_identity_federationchecks ported from ruby'sconfigure(), which previously had no test coverage, plusBigqueryClientconstructor tests for themissing-
project/missing-project_idcases.Test plan
./gradlew test./gradlew spotlessApply🤖 Generated with Claude Code