Repository navigation
[ruby-compat/09] Fix double-encoding when converting json columns to JSON type - #118
Merged
chikamura merged 2 commits intoSep 25, 2026
Conversation
json_column_visitor's else branch put the raw JSON string as a String
value, which BigQuery's JSON loader re-encodes as a quoted string
(e.g. {"msg":"hello"} became "{\"msg\":\"hello\"}"). Set the parsed
value directly for type: JSON instead, matching ruby's json_converter
which just passes the value through unchanged for that type.
Also document type: JSON as a supported column_options conversion
target for json columns in README and BigqueryColumnOption, since it
was previously implemented in ruby but undocumented in both projects.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
chikamura
changed the base branch from
master
to
feature/ruby-compatibility
September 16, 2026 02:09
…n-double-encoding Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chikamura
changed the title
chikamura
marked this pull request as ready for review
September 25, 2026 04:38
10 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonColumnVisitor's else branch put the raw JSON string as a String value, which BigQuery's JSON loader re-encodes as a quoted string (e.g.{"msg":"hello"}became"{\"msg\":\"hello\"}").type: JSONbranch that sets the parsed value directly instead, matching ruby'sjson_converter, which just passes the value through unchanged for that type.type: JSONas a supportedcolumn_optionsconversion target for json columns in README andBigqueryColumnOption, since it was previously implemented in ruby but undocumented in both projects.Test plan
./gradlew test(addedtestJsonColumnWithJsonTypeDoesNotDoubleEncode)./gradlew spotlessApply🤖 Generated with Claude Code