feat(webapp,run-engine,run-store,redis): wire the execution-snapshot store behind an off-by-default dial - #4783
Open
d-cs wants to merge 63 commits into
Open
feat(webapp,run-engine,run-store,redis): wire the execution-snapshot store behind an off-by-default dial#4783d-cs wants to merge 63 commits into
d-cs wants to merge 63 commits into
Conversation
The decorator that dual-writes snapshots to Redis has to own the snapshot id, or the same snapshot carries a different id in each store and the comparator chases a difference that is not real. Four of the six snapshot input types had no id field, so four write sites could not carry one. Add it to CompletionSnapshotInput, ExpireSnapshotInput, RescheduleSnapshotInput and CreateExecutionSnapshotInput, and thread it through every nested create. createCancelledRun built its create inline and dropped the id its input already carried; it now passes it too. The field is optional everywhere, so an absent id still falls through to Prisma's @default(cuid()) and no existing caller changes.
…ators RunStore has 71 members. A decorator that intercepts a dozen of them should not restate the other 59 forwarders alongside its real logic, and hand-writing them invites a typo no test would catch. Generate the base from the interface instead. The generator also emits the member-name lists, so the suite can assert that the class and the interface hold exactly the same members: a method added to RunStore and not to the base fails a test rather than becoming a silent hole in the decorator. The one data property on the interface becomes a getter over the delegate, read live rather than captured, so a delegate whose client changes is not cached.
…parity tests No nested write site returns the snapshot it created: createRun returns the run, expireParkedRun returns a count, and the rest return a selected TaskRun. So the Redis entry is built from each site's own input plus the caller-minted id. That means every value Postgres derives rather than receives has to be reproduced: the DEQUEUED-to-PENDING rewrite, the four values lockRunToWorker hard-codes, the three rescheduleRun defaults, and the engine column default a completion leaves unset. The parity suite covers all ten physical write sites, comparing the built entry against the row Postgres actually wrote. It caught the dropped id in createCancelledRun.
…write The last dial position makes the Redis store the sole snapshot writer, so Postgres has to stop writing snapshot rows without changing anything else it does. One constructor flag does that across all ten write sites. With it off, the nine nested creates are omitted and the run mutation still lands; createExecutionSnapshot echoes its input in the shape callers expect rather than inserting; and the completed-waitpoint join inserts are skipped, since they would otherwise link to a row that no longer exists. Defaults to true, so every existing caller and test is unaffected.
A decorator over any RunStore that also writes execution snapshots to Redis. It overrides only the methods that touch a snapshot and inherits the rest. Write order is the correctness property, and the two orders differ on purpose. A transition writes Postgres first: a crash in the gap leaves a stale latest snapshot, which the heartbeat stall watchdog already heals. A birth writes Redis first: a crash there leaves an unreachable key for a run that does not exist, where Postgres-first would leave a run with no snapshot at all and no way to read one. Each order is chosen so the crash state is the harmless one. A failed transition append retries three times, then hands the run to the repair job. It never rethrows, because Postgres has already committed and a throw would turn a healable gap into a caller-visible error. A failed birth append is survivable before redis-only, where Postgres still holds the snapshot, and refuses at redis-only, where it would otherwise create a run with no snapshot anywhere; refusing works only because the birth append comes first. None of the four non-failure append outcomes enqueues a repair: an absent keyspace is every pre-cutover run's transitions, a fork means another writer advanced the head, a duplicate is a retry that landed, and a cycle mismatch is the store refusing an untrustworthy pointer on purpose. At mode off the decorator makes no Redis call and builds no entry.
…ore handles Proves the deferral from inside the transaction callback rather than assuming it: a staged append is absent from Redis while the transaction is open and present once it commits, and a rollback leaves both stores agreeing the transition never happened.
The engine resolves its since-cursor to a createdAt before it asks for the window, so the snapshot id is gone by then and the id-addressed read cannot serve it. Adding a cursor-addressed read is the alternative to changing the engine's read path, which stays untouched. The cursor is exclusive and keeps the same-millisecond blind spot the Postgres read has. Matching it is the requirement, not an oversight: a Redis read that is more correct than the Postgres read shows up as divergence during compare mode, which exists to surface real defects. Closing the blind spot needs seq ordering on both sides and belongs after the cutover. The walk goes newest-first and stops at the first entry at or before the cursor, so its length is the length of the answer rather than the run's history. This adds a read operation. It does not touch the append script, the keyspace, or the write-ordering protocol.
…back Two of the five snapshot reads take arbitrary Prisma arguments, and a key-value store cannot answer an arbitrary query. Only three production call sites exist, all in the engine's executionSnapshotSystem, and both generic ones send a single fixed shape, so the decorator recognises exactly those shapes and delegates everything else. Each matcher rejects an argument object carrying a key it does not know, because a query that has drifted must be answered correctly by Postgres rather than approximately from Redis. A miss is the coexistence path, not an error: a pre-cutover run or expired history falls back to Postgres. The entry supplies every scalar column, and the checkpoint and waitpoint rows are read back through the delegate only when the entry says they exist, so the common read of a running run makes no Postgres call at all. Which runs read from Redis is a hash of the run id, so a run does not change store between two reads of one poll, two instances of the same dial agree, and raising the dial only ever adds runs to the cohort.
Two rules, because neither can see what the other leaves behind. A terminal run whose keyspace never received the completion expiry gets one applied, so it reaps on the schedule a healthy terminal append would have set. A keyspace with no run row at all, past an age threshold, is deleted outright — that is a crashed birth, which is non-terminal so it carries no expiry and has no run row, so the first rule can never match it. It never reaps on an unknown answer: a live run is left alone however old its keyspace, a young orphan is left for the birth that may still be in flight, and a batch whose run lookup failed is skipped rather than treated as absent. Run rows are resolved through the run store rather than a raw client, because under the run-ops split a run can live on either database and a raw lookup would report a live run as an orphan. Nothing schedules this. The engine's worker has to run it, and run-store cannot reach the engine. Also moves the decorator suites onto the worker-scoped container fixture. The per-test one boots a Postgres and a Redis container for every test, which is what the replication tests need and these do not; the sweeper suite alone went from repeated two-minute timeouts to ten seconds.
…eads on The engine's own flows, driven against the decorator with every snapshot read served from Redis, injected through the store seam that runStoreInjectability already proves. Same flows, same expectations, different store underneath — the point is that nothing in the engine has to know, so no existing suite changes. Covers a run driven to completion, the execution data at each step, a since-window wider than the fifty cap, and a pre-cutover run with no keyspace falling back to Postgres. The environment-boundary test asserts parity rather than a fixed shape: whatever Postgres answers for a foreign environment, Redis has to answer the same, or the tenant boundary behaves differently once reads move over.
…oth stores Three defects, all of which passed the existing suites because no test drove a snapshot that actually carried waitpoints, and because the parity suite compared createdAt against a value it had just read back from the row. The decorator never passed a cycle to the append, so no wp:<cycleSeq> key was written for any snapshot and the completed-waitpoint side of Redis was permanently empty. It now mints a cycle when the id set differs from the current head and carries the previous cycleSeq forward when it does not, so a resume writes the record set once and the copy-forwards that follow write no key at all. The since-window hydration returned an empty completedWaitpointOrder. That column is not the join: the engine reads it off the head row as the oracle that gives each completed waitpoint its position in a batch, so an empty order resumed every batched triggerAndWait with an undefined index. Seven of the eight write sites stamped the entry from the app clock while Postgres stamped its own column default, so the two stores held different instants for one snapshot. The decorator now supplies createdAt, and an equal updatedAt, at every site, and the standalone path supplies it too rather than reading the row back. Beyond making the field comparable, this aligns the since-window: the cursor is resolved from one store and applied in the other, and two different instants misfilter that window. The parity suite gains an independent clock-provenance guard, and a case proving an absent instant still takes the database default, which is what keeps the store's behaviour unchanged while the decorator is off.
…oint The generator that emits the pass-through store base is a runnable script, not dead code, and the same glob covers any script added there later.
…arity real The sweep discovered keyspaces by their cur key, which the append script writes only when an entry is valid. A keyspace whose entries all carry an error has no cur and no index, so neither sweep rule could ever see it and it leaked with no expiry, which is the same unbounded leak the second rule exists to close. It now scans on the entry hash, which every append writes, and the age probe falls back to the newest instant in that hash when the index is empty. Enumerating a run's cycle keys used KEYS. That command iterates the whole database and blocks while it does, and a hash tag routes a key without scoping the scan, so a sweep pass would have issued one full keyspace scan per run. It now reads the dense cycle high-water counter the append script maintains, which is the same source the store's own terminal-expiry loop uses, and pipelines the existence checks into one round trip. The timestamp parity assertion was still tautological. The previous commit added a note saying the builders receive an independent instant and did not change the builder calls, which kept reading the value off the row under test. Every case now mints one instant, passes it to the store, and gives the builder the same value, so a write site that stops forwarding the caller's instant fails here. Also documents what an injected fault actually does at each write path, since only the birth path rethrows, and scopes a run count in the chaos suite to the environment under test.
Review asked why the pass-through base is tested against a hand-built delegate rather than a real store. Checking what the compiler already guarantees showed the test's own stated reason was wrong, and that one of its cases could not fail. implements RunStore already rejects a missing member with TS2420, so the claim that a method added later would become a silent hole was not true. The case comparing the class against the generated name list could not detect a parse miss either, because both the class and the list come from one parse of the interface, so a miss drops the member from both sides. The generator's comment asserting otherwise was false. Parity now lives where it can actually fail: assertions tying the name lists to keyof RunStore in both directions, and one rejecting a public member the class declares and the interface does not. They sit in src rather than in a test, because the build config excludes test files, so a type assertion written in a test is never checked. Each was verified by making it fail. What the compiler cannot see is inside the forwarder bodies, since every one is typed (...args: any[]): any. A forwarder wired to the wrong member, or dropping an argument, typechecks cleanly. The remaining probe covers exactly that, using a per-member sentinel so a misrouted body returns the wrong value rather than merely returning something. Verified by rewiring a forwarder: typecheck passes, the probe fails and names the member. Renames the double to forwardingProbe across both suites and says at the top why a container cannot replace it: no database is involved in whether a pass-through passes through.
A member was removed from the generated list while verifying that the new parity assertion fails when one goes missing, and the restore did not run, so the verification state was committed. Regenerated from the interface. The assertion did its job: typecheck rejects the list, naming the missing member.
…ecorator-tri-13449
… client key prefix Two defects from review, both silent. An append staged inside a transaction dropped its expected-head argument, and the post-commit flush passed undefined in its place. That disabled the compare-and-set for every snapshot written inside a transaction, which is the path both engine transaction writers use, so a stale append that the store would have refused as forked was written instead and became the head. The expectation now travels with the staged entry. The sweep built its scan pattern without the client key prefix. ioredis prepends that prefix to keys for ordinary commands but not to a SCAN MATCH pattern, and returns matched keys with it still attached, so a prefixed client made the sweep match nothing and report a clean pass. The engine sets a prefix on every other Redis client it builds, so this would have surfaced at wiring time as a reaper that silently protected nothing. Also removes a keyPrefix option on the sweep that could never work: the keyspace prefix belongs to snapshotKeys in the store, which writes snap: keys unconditionally, so there was no other keyspace to point it at. Both fixes have a test verified by reintroducing the defect: the staged stale append is written without the guard, and the prefixed sweep scans nothing.
… source The generator was scaffolding for a one-off job: writing 70 near-identical forwarders. Keeping it meant carrying a hand-rolled scanner over the interface body, because the TypeScript compiler API is not resolvable in this workspace, which is more machinery than a file that changes only when the interface does. The two files it produced are now maintained by hand, and their headers say so. Nothing is lost, because the generator was never what guaranteed they were right. That is the compiler: implements RunStore rejects a missing member, and the parity assertions tie both name lists to keyof RunStore in each direction and reject a public member the interface does not declare. Each was re-verified by making it fail after the generator was removed. Also drops the knip entry that existed only to treat that script as an entry point.
The sweeper needs to know which run statuses are terminal and cannot import the list, because run-engine depends on run-store rather than the other way round. The copy's comment claimed a parity test kept the two equal. No such test existed, so the claim was false and the copy could drift silently. Drift is not symmetric. A status added to the engine and not the copy makes the sweep treat a finished run as live and never apply its completion expiry. A status removed from the engine and not the copy makes it treat a live run as finished, and that reaps state a run is still using. Verified by removing a status and rebuilding: the test fails and reports seven members against eight.
The forwarders were (...args: any[]): any, so the compiler could not see inside them. A body that called the wrong delegate member, or reordered its arguments, typechecked cleanly. That is not a theoretical gap: it is why a runtime probe existed to catch it, and it is the same shape of hole that let three other defects on this branch pass a green suite. Every member now restates its interface signature and forwards its arguments by name, so both mistakes are compile errors. Verified by making them: a forward to the wrong member produces two type errors, and swapping two arguments produces one. Seven members are overloaded. TypeScript cannot express a single body that satisfies an overload set, so their overloads are declared for callers and their one implementation forwards through a cast. That cast is now the only place the compiler is not checking the forward. The probe shrinks to what is left: those seven casts, a dropped OPTIONAL argument (omitting a trailing tx compiles and silently stops forwarding the transaction), and whether the data property is read live or captured once. Its header states which of those the compiler already covers. Headers on both files now describe what they are rather than that they were once scaffolded.
Typing the forwarders closed the wrong-member and reordered-argument holes but not this one: omitting a trailing OPTIONAL argument still compiles. Two forwarders did exactly that, because the retyping pass read parameter names with a pattern that a preceding inline comment defeated, and both affected parameters happened to be optional and commented. The effects were silent and not small. findLatestExecutionSnapshot stopped applying its tenant scope, so a direct use of the base could read across the environment boundary. upsertWaitpointTag stopped applying its residency hint, so a tag write for a new-database environment would land on legacy. A source-level guard now asserts that every single-signature member forwards exactly the parameters it declares, in order. It reads the interface and the base and compares them, because that property is invisible to the compiler by definition. It carries a vacuity check, so a parse failure fails the suite instead of quietly matching nothing, and that check earned itself immediately by catching a parser that skipped every generic member. Verified: with a parameter dropped again, typecheck reports zero errors and the guard names the member and the missing argument.
A completed waitpoint with no batch index was invisible to every Redis read, so a run resumed from the store lost that wait's result while Postgres still returned it. That is every wait.for, every single triggerAndWait and every token: the engine passes index as batchIndex ?? undefined, so only waits inside a batch carry one. The cause was reading the id set out of the ordered list. That list is the index oracle and its positions ARE the indexes, so it can only ever hold indexed ids, and deduping it yields a set missing exactly the index-less ones. Postgres has no such restriction: its completed-waitpoint join records every id. The cycle key now carries the complete distinct set in its own field, written when the cycle is minted and read back beside the order. The order keeps its meaning and stays index-only. Two tests: one asserting an index-less wait survives a round trip with an empty order, and one asserting the set matches the Postgres join for a mix of indexed and index-less waits. Verified by deriving the set from the order again, which makes the waitpoint vanish. The suites missed this because every earlier case gave each waitpoint an index.
The previous fix stored the complete id set but left three places still deriving it from the ordered list, and the ordered list holds only batch-indexed ids. A carry-forward decided on the order alone. Two DIFFERENT single waits both present an empty order, so they compared equal, the second inherited the first's cycle, and a read returned the wrong waitpoint entirely. The comparison now requires the id set to match as well. The dequeue site built its Redis refs from the ordered list while the delegate connects the complete set in Postgres, so an index-less waitpoint reached Postgres and never reached Redis. Refs are now built from the complete set, with the index taken from the ordered list where the id appears in it. The entry decode derived the set from the order too, which meant getLatest and getById returned an incomplete set. That is the hot read: findLatestExecutionSnapshot hydrates the waitpoint rows from it, so a resume would have fetched no row at all for a single wait. The read scripts now return the stored set alongside the order. Four tests, each verified against its own defect: two consecutive single waits keep separate cycles, a repeated one still carries forward, the dequeue snapshot keeps an index-less id, and the hot read hydrates its row.
A sweep for values derived where they should be read found one more. The hydrated payload left out lastHeartbeatAt entirely, so a Redis-served read returned undefined for it where Postgres returns null. No code writes that column, so null is not a guess: it is the only value Postgres ever holds. The effect was small but constant, on every read served from Redis, and it is the kind of difference a comparator has to either explain or chase. Guarded by comparing the KEY SET of the two payloads rather than their values, so a column omitted by the hydrator fails as a missing key rather than passing as an absent value. Verified by removing the line again: the test names the column. Also covers the timestamp write on both schema variants. updatedAt is declared @updatedat, which Prisma manages, so whether an explicit value survives a create is a property of the client rather than of the schema, and the two variants are separately generated clients. Agreeing declarations were not evidence. Both honour the caller's instant.
An independent pass hunting one shape, a value derived where it should be read, found these. None was reachable from a test that existed. The hot read paid a second Redis call in its most common case. An entry with no wait cycle has no waitpoints by construction, and the hydrator asked the store to confirm that rather than concluding it, on every read of a run that is not resuming from a wait. It now distinguishes the three cases and only asks when it genuinely does not know. decodeWaitpointIds still reconstructed the id set from the ordered list when the stored set was absent. That is the sixth instance of the bug fixed five times, surviving as a fallback. It is unreachable today, because both fields are written by one command, but the reconstruction is lossy by nature and the loss is silent. A missing set beside a non-empty order now reports the entry as not present, which sends the caller to Postgres. The window read checked one liveness anchor where the append script deliberately checks two and explains why. An index lost to eviction while the entry hash survived would have reported an empty hit rather than a miss, so the poll would have returned nothing new for the rest of the run's life while Postgres held the transitions. The wrapped store handle dropped the staging buffer, so a handle taken inside a transaction would have appended before the commit. No caller writes a snapshot through it today. Also restores excess-property checking on the nested snapshot writes. Routing them through a generic helper let a typo'd field name compile and fail at runtime; a concrete parameter type brings the check back at the five sites that pass a fresh literal. Verified: a bogus field is now TS2353.
Two paths reached the same silent hang, and neither had a test. When the store refuses a carried pointer it was still writing the entry, which then became the run's head with no pointer at all. A read of that answers present-with-nothing, and present-with-nothing is precisely the signal that tells the engine's read-repair it does not need to look, so the runner got a waitpoint-less continue and dropped it. Refusing the pointer stays right; the append now mints a fresh cycle from the refs the caller carried, in the same atomic call, so the entry always has a pointer that can be trusted. Refs are optional and only the fallback needs them, so callers that supply none keep the previous behaviour. The second path needs no refusal at all. An entry whose cycle key has gone still carries its pointer, and the read answered empty for it too. That is reachable by eviction and also by the completion expiry, which is applied to every key for a run at one moment but lets them expire independently. Reads now report such an entry as not present, which sends the caller to Postgres, where the join rows still are. The hot read and the window both fall back rather than serve it. Three tests. The refusal is driven at the store, because the decorator cannot reach it on purpose: its probe sees the id set no longer matches and mints a new cycle, so the refusal only happens when the key vanishes between probe and append. Each verified against its own defect.
At that position Postgres holds no snapshot rows, so a run routed away from Redis by the cohort percentage reads nothing at all. The percentage is only meaningful while both stores hold the data. Fixing it in the dial rather than documenting the constraint makes the combination unreachable, instead of leaving three settings that have to agree by convention.
…ecorator-tri-13449 # Conflicts: # internal-packages/run-store/src/index.ts
…edis cluster SCAN carries no key, so a cluster cannot route it: one connection iterates one node's keyspace and then reports a completed cursor. The sweep now fans out over every master, resolved per pass so a failover cannot leave it scanning a stale node list, and reports how many it covered. Rule 2 deletes a whole keyspace when the run lookup returns no row. That lookup partitions ids by residency and reads each store's replica, so an absent row is not proof of absence. Deletion now needs the keyspace to be seen absent in two separate passes, and any run found to exist clears its mark. Both window reads returned the head's waitpoint order without its dangling flag, so a head whose cycle key had expired came back with an empty order rather than falling back to Postgres, losing every position on a batched resume. Also lets both classes take a caller-built client so they can reach a cluster at all, and gives the sweep a deadline and an abort signal so a pass can stop inside its budget instead of being killed mid-cursor.
…ecorator-tri-13449
Both survived earlier revisions of the same change and now describe behaviour the code does not have. One claimed the marker has a TTL derived from the confirm window; it is a hash field with no TTL. The other claimed the marker is cleared only for terminal runs, when it is cleared for every run the lookup returned, which is what stops a live run's stale marker from pre-authorising a later deletion. Both sit on the path that deletes a keyspace, so a reader acting on either could reopen the hole the two-sighting rule closes.
…i-13449' into feat/snapshot-store-wiring-tri-13451 # Conflicts: # internal-packages/redis/src/index.ts
…redis-only `compare` was a name in the dial with no behaviour behind it: it wrote and read exactly as `dual-write` does, so turning it on would have looked like enabling divergence reporting and delivered plain dual-write. A dial value that silently does something other than its name is worse than a missing one. It returns with the ticket that implements the sampled dual-read and diff. `redis-only` was the thinnest tested position and the only one that cannot be rolled back, since the snapshots written while it is on exist nowhere else. It is also the only position that is a PAIR of settings, the decorator's mode and `snapshotWrites: false` on the store beneath it, and the previous single test used a store that still wrote snapshots. Every test in the new suite builds the pair, and covers the run mutation landing without its snapshot row, transitions, completions, the absent waitpoint join rows, and every read being Redis-served. One test characterises rather than endorses: a read shape the decorator does not recognise is delegated, and at this position Postgres holds nothing, so the caller gets an empty result rather than an error. Only the engine calls that method and it issues the recognised shape, so nothing is broken today. It is pinned so the terminal-cutover ticket decides deliberately whether a fall-through here should throw instead of answering empty.
…load Six webapp test shards failed on import with "At least one of max, maxSize, or ttl is required". The organisation cache was built by a top-level singleton call, so importing the module read two new environment variables. Many webapp suites mock the env module with a minimal object, so both came back undefined and the LRU constructor threw, taking the whole file down before any test ran. The cache is now built on first use rather than at import, so the module has no load-time side effect at all, and its two options carry inline defaults so a partial env cannot throw. The environment floor is read defensively for the same reason. Covered by a test that mocks the env module the way the suite that caught this does. Reintroducing either half of the fix fails it.
…tract The store now receives a pre-built client instead of building its own, so cluster mode reaches the hot path and not only the sweep. The webapp owns both sockets and closes both, with the hot-path client last so an append in flight can still land. The sweep receives the dedicated client, the confirm window that was parsed and unused, and the deadline and abort signal it now accepts. So the pass budget is enforced inside a pass rather than only bounding the lock, and a truncated pass reports itself as partial. The engine also arms an abort a minute past the budget. The deadline is the sweep's own stopping rule, checked at batch boundaries; this is the backstop for a pass that has stopped reaching one, so the signal is not decorative.
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
…probe a CI-only failure The dial positions are declared locally rather than imported, so this module no longer depends on the run-store package's build output to typecheck. An assertion keeps the two in step and fails loudly if either gains or loses a position. That is worth doing regardless, but it does not explain the failure it was prompted by. This module typechecks clean locally, on a clean rebuild of run-store from the same source, under both source and built resolution, and under the same command CI runs. It fails in CI with three errors that are only mutually consistent if the imported type resolves to never there. So this also carries a temporary probe whose reported type names which case CI is in. It comes out in the next commit once the answer is in the log.
The probe deliberately fails: the compiler names the union members in the message, so the CI log states exactly which positions it sees. Local output lists all five. Comes out in the next commit.
…i-13449' into feat/snapshot-store-wiring-tri-13451
The base branch removed compare from the dial as an unimplemented position. CI builds the pull request's merge ref against the current base, so it saw four positions while this branch still had five, and reported it as three type errors that named neither cause. My clone was simply stale. So compare goes from the environment schema, both flag catalog entries, the resolver's local unions and the tests. The per-organisation key is now off and dual-write, which is every write position there is. The drift assertion added while chasing this stays. It is what turned an obscure failure into a statement that two definitions disagree, and it will catch the next divergence the same way. Both temporary probes come out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
… wiring The sweep handler caught its own failure, logged it and returned, which acknowledges the job. The dead-letter path is what re-enqueues the next occurrence, and only a throw reaches it, so one transient failure would have stopped the sweep for good. It now rethrows after the outcome is recorded. The save guard only covered the global dial, so an organisation could be set past off with no connection configured and silently do nothing, which is the exact silence the guard exists to prevent. It now covers both keys and runs on the organisation routes as well. A companion check refuses the per-organisation key on a global save, where nothing reads it. Invalidation read the replica immediately after a primary write, so replica lag could re-cache the value the write had just replaced and hold it for the whole cache window. That is worse than not invalidating at all. Invalidation now drops the entry and re-reads from the primary; the background warm-up keeps the replica. A pass cancelled at shutdown reported itself as failed. It now reports aborted. Metric attributes are bounded at the adapter and in the engine's option type. The values were already bounded in practice, but both sides typed them as plain strings, so an unrecognised value now collapses to a single bucket rather than minting a time series. Also drops mocks from the boot test, which the injected dependencies made unnecessary, and replaces a dial position in the run-store test that no longer exists.
d-cs
commented
Aug 26, 2026
Base automatically changed from
feat/snapshot-store-decorator-tri-13449
to
main
August 26, 2026 13:20
…iring-tri-13451 # Conflicts: # internal-packages/redis/src/index.ts # internal-packages/run-store/src/taskRunExecutionSnapshotStore.off.test.ts # internal-packages/run-store/src/taskRunExecutionSnapshotStore.staging.test.ts # internal-packages/run-store/src/taskRunExecutionSnapshotStore.ts
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…rg cache against a stale read Two review findings, plus a correction of my own. The engine recorded whatever count keys a pass returned, and each key is a metric attribute, so an unrecognised one would mint a time series. Keys are now filtered against a fixed list at the point of record, matching the allowlist the webapp adapter already applies. A replica read that started before an invalidation could land after the primary read and put the superseded value back in the cache, holding it for the rest of the window. Each organisation now carries a generation that invalidation increments, and a load whose generation is no longer current discards its own result. The correction: an earlier commit made the sweep failure path rethrow, on the stated grounds that only the dead-letter path re-enqueues the next cron occurrence. That is wrong. The worker reschedules a cron job on the acknowledge path as well, so returning normally always continued the chain. Throwing only added a dead-letter entry for every transient failure. Both rethrows are reverted and the reason is recorded at each site, because the claim reads plausibly and would otherwise be reintroduced.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/webapp/app/v3/snapshotStoreMode.server.ts (1)
94-107: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd crumb markers to the new code before merge.
apps/webapp/app/v3/snapshotStoreMode.server.ts#L94-L107: Add a//@Crumbsmarker or `// `#region` `@crumbsblock for the invalidation path.internal-packages/run-engine/src/engine/index.ts#L2979-L2992: Add a marker for sweep failure and metric handling.internal-packages/run-engine/src/engine/types.ts#L61-L69: Add a marker for the new sweep metric field definitions.As per coding guidelines, “Add crumbs as you write code” and strip them before merge.
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d031beaa-ed2e-4c01-ade9-ec70dbbe1760
📒 Files selected for processing (4)
apps/webapp/app/v3/snapshotStoreMode.server.tsapps/webapp/test/snapshotSweepRunner.test.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/webapp/test/snapshotSweepRunner.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (29)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (14, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (19, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (22, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (13, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (17, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (21, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (16, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (24, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (15, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (23, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (20, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (18, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 24)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp (2, 2)
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp (1, 2)
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (10)
New code must target Run Engine V2 through the singleton in `app/v3/runEngine.server.ts`; do not reintroduce V1 execution paths. V1 branches may only reject or finalize gracefully with a clean 4xx.
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.ts
Never use `request.signal` to detect client disconnects. Use `getRequestAbortSignal()` from `app/services/httpAsyncStorage.server.ts`, which is wired to Express response close events.
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.ts
For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.ts
**Prefer static imports over dynamic imports.** Only use dynamic `import()` when:
📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
Add crumbs as you write code — not just when debugging. Mark lines with
📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
Use zod for validation in packages/core and apps/webapp
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.ts
Access environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env`
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.ts
Use function declarations instead of default exports
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
Use types over interfaces for TypeScript
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
Files:
apps/webapp/app/v3/snapshotStoreMode.server.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/types.ts
🧠 Learnings (1)
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-engine/src/engine/types.ts
🔇 Additional comments (1)
internal-packages/run-engine/src/engine/index.ts (1)
350-356: 📐 Maintainability & Code QualityKeep
_totalin the counter name. The OpenTelemetry Prometheus/OpenMetrics contract appends_totalonly when it is absent, so this name does not becomesweep_pass_total_total.
The type was exported and nothing outside the package consumed it, which the dead-code gate reports as an unused export. Deriving it from the list that the runtime filter already uses removes both the export and the duplication, so the filter and the type cannot drift apart.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal-packages/run-engine/src/engine/types.ts (1)
53-72: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd crumbs to the new snapshot-sweep declarations.
Lines 53-72 and 196-198 add new code without a
//@crumbs`` marker or an@crumbsregion. Add the required crumbs instrumentation while developing these blocks; `agentcrumbs strip` will remove it before merge.As per coding guidelines, add crumbs as you write code, not only when debugging.
Also applies to: 196-198
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 794f8380-e209-4143-8498-07b440944bc8
📒 Files selected for processing (1)
internal-packages/run-engine/src/engine/types.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (32)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (24, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (22, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (14, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (23, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (18, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (20, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (16, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (21, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (15, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (13, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (19, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (17, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 24)
- GitHub Check: typecheck / typecheck
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: obsmap / 🧪 Unit Tests: Observability Map
- GitHub Check: runops-guard / runops-guard
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp (1, 2)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp (2, 2)
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (5)
**Prefer static imports over dynamic imports.** Only use dynamic `import()` when:
📄 CodeRabbit inference engine (AGENTS.md)
Files:
internal-packages/run-engine/src/engine/types.ts
Add crumbs as you write code — not just when debugging. Mark lines with
📄 CodeRabbit inference engine (AGENTS.md)
Files:
internal-packages/run-engine/src/engine/types.ts
Use function declarations instead of default exports
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
internal-packages/run-engine/src/engine/types.ts
Use types over interfaces for TypeScript
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
internal-packages/run-engine/src/engine/types.ts
When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
Files:
internal-packages/run-engine/src/engine/types.ts
🧠 Learnings (1)
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-engine/src/engine/types.ts
d-cs
marked this pull request as ready for review
August 26, 2026 14:58
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…he sweep delivery window
Two findings from a second reviewer.
The append counter was incremented by both layers: the store's append with
{outcome, ttl}, and the decorator's write with {site, outcome}. So one logical
write counted twice, and the series carried inconsistent attribute keys, which
makes any sum or grouping over the name meaningless. The decorator now has its
own counter. A source assertion keeps them apart, since merging them again reads
like a tidy-up.
The sweep job's delivery window was a fixed value while the pass budget is
configurable, so raising the budget past that value would put the runner's lock
TTL above the window and let a redelivery arrive while the previous pass still
held the fence. The window is now derived from the budget, with the ordering
covered for a range of budgets rather than only the default.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Every write entry point resolves the rollout position for the run own organisation, but the decision about whether a lost run-birth append is fatal still read the global position. An organisation whose own position keeps Postgres authoritative could therefore have run creation failed by a transient Redis fault. It now reads the same per-organisation position that decided to append in the first place.
The snapshot store connections and the orphan sweeper now close on SIGTERM and SIGINT, matching the other Redis-backed singletons.
Comment on lines
+201
to
+202
| // The dial is deployment-wide; only snapshotStoreOrgMode is per-org. | ||
| FEATURE_FLAG.snapshotStoreMode, |
Contributor
There was a problem hiding this comment.
🟡 Org-only snapshot dial appears editable on the global flags page
snapshotStoreOrgMode is a per-organisation-only flag but is missing from GLOBAL_LOCKED_FLAGS, unlike every other org-scoped-only flag. The convention noted just below (featureFlags.ts) is that such flags go there so the global page renders them read-only. Instead the global flags page shows an editable control for it, and setting it fails the save with a 400 from globalOnlySnapshotStoreFlagError.
Prompt for agents
snapshotStoreOrgMode is a per-organisation-only flag: no save path reads it from the global row (globalOnlySnapshotStoreFlagError rejects it on the global routes). The comment above GLOBAL_LOCKED_FLAGS (apps/webapp/app/v3/featureFlags.ts around lines 170-173) states that org-scoped-only flags must be listed in GLOBAL_LOCKED_FLAGS so the global admin page (admin.feature-flags.tsx) renders them read-only rather than offering an inert editable control. snapshotStoreOrgMode was added to the catalog and to ORG_LOCKED_FLAGS, but not to GLOBAL_LOCKED_FLAGS, so the global page shows an editable enum control for it that then errors on save. Add FEATURE_FLAG.snapshotStoreOrgMode to GLOBAL_LOCKED_FLAGS to match the convention and the other org-scoped-only flags.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Observability mapAs of 20/100 over 449 measured of 467 entry points (base 19, up 1) What this PR changed
FIX FIRST
AUDIT 3 of 50 sensitive mutations record an actor. 47 without one. What the score is made ofThe score and findings here are report-only and never gate the merge. Separately, a required test suite keeps this tool's symbol and route lists in sync with the code they name, and can fail a pull request that renames or removes a symbol they reference, or that adds the first route with a segment they anticipate. Each failure names the list to edit. The rules and their reasons: internal-packages/observability-map/README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Redis-backed execution-snapshot store reachable from production, off by default.
With no
RUN_ENGINE_SNAPSHOT_STORE_REDIS_HOSTset, nothing is constructed, no connection is opened, no metric series is registered and no job is scheduled, so the store chain behaves exactly as it does today. A fresh self-host is in that state: none of the new variables appear in.env.example, the docker files, or the Helm chart. The dial cannot activate anything on its own either, because construction is gated on the connection rather than on the dial.Once the connection is configured, expect three Redis connections and the orphan sweep running on its cron schedule, at any dial position. The sweep runs at every position on purpose: an operator has to observe a full pass before dual-write starts. Until the dial moves, the keyspace is empty and a pass finds nothing, but it is not nothing.
Stacked on #4765, which builds the store and the decorator. Review that one first.
The dial is a feature flag, not an environment variable
A sustained append failure burns a task attempt on every state transition, so runs can exhaust their retry budget on infrastructure failure rather than task failure. Dialling down is therefore a correctness control, and it cannot wait for a deploy.
Two catalog keys, because they must accept different values:
snapshotStoreMode(global) holds all five positions.snapshotStoreOrgMode(per organisation) holdsoff,dual-writeandcompareonly.Snapshot reads are global, so an organisation at a read position would read state its own writes never created. The narrower enum makes that unrepresentable rather than documented.
ORG_LOCKED_FLAGSturns out to enforce nothing (it is a client-side predicate and no save path consults it), so the line is held the way the mint grace stamps hold it: both organisation routes strip the global key from an incoming payload.The environment keeps what cannot be hot-swapped, plus
RUN_ENGINE_SNAPSHOT_STORE_MODEas the floor used when no flag row exists, so a self-host install still works with no rows at all. No variable falls back to the genericREDIS_*: this is a distinct durable endpoint, and a fallback would silently put execution state on the general-purpose cache.The resolver never queries
The dial is read on every snapshot write, while the per-run lock is held. Seven decorator methods accept a caller-supplied transaction, so this code cannot see a caller's transaction boundary, and an awaited read could land inside someone else's open interactive transaction, on the same connection pool for single-DB and self-host.
So the resolver is synchronous. The global value comes from the existing
globalFlagsRegistry, already an in-memory snapshot read synchronously on the trigger hot path. The per-organisation value comes from a bounded LRU. A miss returns the global answer and warms the cache off-path, so a cold organisation costs no round trip and a control-plane blip cannot fail a state transition.Gating, and the sweep
Construction is gated on the connection, not the dial. The store's options require a constructed Redis store, that store opens its socket in its constructor, and the client factory sets no
lazyConnect, so building it unconditionally would open a doomed localhost connection in every self-host install, developer machine and CI run.The orphan sweep runs as a cron job on the engine's existing worker.
enqueueOncegives no overlap protection (its dedup record is the queue item and the ack deletes it, and nothing extends the visibility timeout), so each pass takes a fenced lock released with a compare-and-delete. A bareDELwould let a pass that overran its own lock delete its successor's.The append-failure hook binds to the existing repair job, sharing the stall watchdog's job id and its
availableAt, so the two compensators can never enqueue two repairs for one run and neither can win a race that changes the delay.Notes for review
Three existing assertions changed, deliberately.
runInTransactionnow always installs the staging facade andforWaitpointCompletionalways wraps its handle: both were conditional on the dial, which cannot work once the dial moves at runtime and a per-organisation value lives in an organisation row. The replacements assert the property that matters, that nothing is appended atoff.@internal/redisgains a cluster-capable client. Cluster mode currently reaches the sweep connection but not the hot path, because the Redis snapshot store still builds its own single-node client; that becomes a one-line change once its options accept a pre-built client.Six guards are verified by reintroducing the defect rather than by observing a pass: the organisation key strip, the module-scope instrument check, the construction gate, the graded boot check, the lock fence and the repair job id each fail when their guard is removed.
Three items are threaded and not yet honoured, because they need #4765's store API: the sweep budget, the abort signal, and
CONFIRM_ORPHAN_AFTER_MS. Cluster mode reaches the sweep connection but not the hot path for the same reason. Each is commented at its site.No changeset and no server-changes entry: the dial defaults off,
@internal/redisis not consumed independently, and nothing user-visible changes yet.