feat(oauth): present pending device grants - #125
Merged
Conversation
Contributor
Author
|
Refreshing the durable PR record validation after completing the required template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Authenticated Admin users can inspect a pending CLI device grant before approving it. The API returns only client identity, user code, requested scopes, pending status, and expiry; it never returns the device credential.
Work authority
Contributor mode (select one):
Plan
Consume the versioned SDK presentation contract, add a fail-closed store read and authenticated no-store protocol route, then verify the complete control-plane suite. Complete.
Changes and commits
Verification
npm run build:dist— passed.npm run test:control-plane— 58 files and 181 tests passed.PR verify and authorization checks passed.
I ran the narrowest relevant package verification and documented any checks that could not be run.
Risk and rollback
The new GET is authenticated, no-store, read-only, and rejects unknown, expired, or non-pending grants. Roll back commit fe4a081 and restore the prior SDK dependency to remove it; the existing POST and token protocol remain compatible.
Completion summary
The API half of the single-credential device-consent flow is implemented and verified. Admin PR #38 consumes it; the next action is exact RC composition verification.
AGPL committer authorization
The base-owned workflow checks the provider-authenticated pull-request author against
.github/approved-committers.json. There is no per-PR grant checkbox. If the check reports that the GitHub username is unapproved, follow the linked one-time approval form and re-run the check after the reviewed allowlist change reaches this target branch.Submission checklist