fix(api): preserve account revision on invalid deletion

[adrianwebb]

Outcome

Invalid account-deletion confirmations no longer advance the account revision, so a corrected destructive request can succeed without a refresh.

Work authority

• Work item / Issue: Closes Validate account deletion confirmation before claiming revision #121
• Proposal / decision: Approved Admin/Core/UI/Reviewer migration plan in the active Codex task
• Assignment / checkpoint: Integrated identity and team browser guarantee proof 59
• Actor: codex-root
• Human authority: @adrianwedd
• Agent / capacity provider: Codex local development session dev-f9dfe127-231
• Exact base ref: staging c95120d
• Exact head ref: codex/account-delete-confirmation-concurrency cb00851

Contributor mode (select one):

• Human-authored
• Agent-assisted under human authority
• Agent-authored under human authority

Plan

Reproduce the stale-revision failure, validate the exact phrase before the atomic claim, add a no-mutation regression, and rerun the integrated graph. Implementation is complete; composition verification is in progress.

Changes and commits

• cb00851 validates the exact destructive phrase before claimAccountRevision and adds the regression.

Verification

• I ran the narrowest relevant package verification and documented any checks that could not be run.
• npx vitest run tests/unit/control-plane/account-operations.test.ts: 12/12 passed.
• GitHub verify workflow: passed.
• Local API development rebuild: generation 3, ready.
• Full tsc remains affected by pre-existing stale SDK hydration/export failures; no reported failure is attributable to this patch.

Risk and rollback

Risk is limited to ordering an existing exact-confirmation validation before an existing concurrency claim. Roll back by reverting cb00851; no schema or durable-data migration is involved.

Completion summary

The API no longer mutates concurrency state for a rejected deletion phrase. Integrated browser proof confirms account deletion proceeds; the final deleted-login scene alignment is being rerun separately.

AGPL committer authorization

The base-owned workflow checks the provider-authenticated pull-request author against .github/approved-committers.json.

Submission checklist

• The change is bounded to the stated work item and target repository.
• Exact base and head refs are recorded and the branch is ready for review.
• Verification and compatibility evidence are recorded above.
• No plaintext secrets, credentials, machine state, or unrelated residue are included.
• Plan, status, commits, and completion summary form a complete durable record.
• Rollback or recovery steps are documented and executable.