Fix sample/weight misalignment in tp_parse_smc() & tp_parse_mcmc() - #30
Open
foersterst wants to merge 5 commits into
Open
Fix sample/weight misalignment in tp_parse_smc() & tp_parse_mcmc()#30foersterst wants to merge 5 commits into
foersterst wants to merge 5 commits into
Conversation
…s. Update to the function's documentation.
…ut JSON file(s). Includes updated documentation.
… we might need this column for post-processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing the list produced by
tp_run(),unlist()silently broke alignment between samples and weights when mixed types (e.g., number and -inf; note that -inf (lowercase) is read by R as character rather than-Inf) or multi-value samples were present.TreePPL Release Notes
Added
Changed
tp_parse_smc()andtp_parse_mcmc(). Changed their output objects to tidy data frames.Deprecated
Removed
Fixed
tp_parse_smc()andtp_parse_mcmc()now parse per-particle/iteration with explicit indices and (for SMC) join weights by index usingleft_join(..., by = "particle")instead of relying on positional recycling, which is the default behavior ofdata.frame()when handling vectors of different lengths.Security