Repository navigation
Use Node 26 for signature parity tooling - #93
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 9 9
Lines 363 363
Branches 46 46
=======================================
Hits 359 359
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature parity should exercise the SDK against Node 26 tooling. Pin the CI and development Docker runtimes to Node 26.12.1, while preserving Ruby 3.1–4.0 compatibility coverage, the published Ruby support floor, and the existing Ruby 4.0 development base image.
Validation: the Docker image builds and reports Node v26.12.1. In a clean archive fixture,
bundle exec standardrband the full existing Ruby suite with Node parity enabled pass: 140 tests, 364 assertions, no failures or errors; only the optional live upload is skipped. Workflow YAML parsing andgit diff --checkpass. Council review: no issues found. Normal CI retains its existing live upload job.Validated commit:
b1a5737b55ccce8dc86c23f4c4ea27a2ae0383d2.🤖 Claimed by kvz on
framework1/ruby-sdksince 2026-10-21 · resume:codex resume 01a15ee6-8ad4-7ec2-a0c6-c6d3ac36a367