Standardize desktop GLFW/GLEW on vcpkg; fix CMake FetchContent warnings - #258
Merged
Conversation
added 3 commits
September 6, 2026 16:07
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e908335. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
vcpkg.json+ toolchain); remove NuGet andthirdParty/path glue so local matches CI.CMP0135,MakeAvailable(lua), pybind11 policy floor, googletestv1.15.2).EzyCad_libso ImGui backends resolveGLFW/glfw3.h.Closes #257
Test plan
-DCMAKE_TOOLCHAIN_FILE=%VCPKG_ROOT%/scripts/buildsystems/vcpkg.cmake+ OCCT 8 paths (match generator to IDE: VS 17 or 18).EzyCad_lib/EzyCad(RelWithDebInfo); run briefly.glfw3.dll/glew32.dllstaged next to the exe.windows-msvc.ymlgreen (already vcpkg-based).Note
Medium Risk
Build and runtime dependency acquisition for all Windows desktop developers changes (vcpkg required); misconfigured local setups will fail configure until the toolchain is set correctly.
Overview
Desktop MSVC builds now get GLFW and GLEW only through the repo
vcpkg.jsonmanifest and-DCMAKE_TOOLCHAIN_FILE=.../vcpkg.cmake, matching CI. The NuGet install/link/copy glue underthirdParty/is removed; configure fails with a clear message if MSVC is used without vcpkg.CMake finds glfw/GLEW via vcpkg CONFIG packages (with MODULE fallback on non-MSVC), links them PUBLIC on
EzyCad_libso ImGui GLFW/OpenGL backends compile, and stagesglfw3.dll/glew32.dll(and debugglew32d.dll) from vcpkg install roots into Release/Debug output dirs. Test targets no longer duplicate GLFW links. FetchContent tweaks: CMP0135, policy floor for pybind11 on CMake 3.31+,FetchContent_MakeAvailable(lua)instead of Populate, googletest bumped to v1.15.2..gitignoreadds/vcpkg_installed.Docs (README, local-dev, building-occt, third_party/README, CHANGELOG) now describe vcpkg prerequisites instead of NuGet; OCCT still comes from prebuilts, not vcpkg.
Reviewed by Cursor Bugbot for commit 8f789ae. Bugbot is set up for automated code reviews on this repo. Configure here.