release-train: staging -> main - #157
Merged
Merged
Conversation
…#2671) (#154) Production docs told users to run pip install "tracebloc[tensorflow]". The SDK publishes no such extra -- 1.0.2 has pytorch, sklearn, xgboost, catboost, lightgbm, lifelines, scikit-survival, all and dev. This is not cosmetic. pip WARNS and exits 0 on an unknown extra, so the command appears to succeed while installing the core SDK only, and the failure surfaces much later as a missing framework. Second defect, found while fixing the first: `all` was annotated "all frameworks" and "everything". It resolves to pytorch, sklearn, lifelines and scikit-survival -- it does NOT include TensorFlow. Both annotations corrected to name what it actually pulls in. The SDK does handle TensorFlow in code (weight_loaders, rewriter, loss, augmentation, safetensors_io), it simply is not packaged as an extra. The Note states that fact and stops there rather than inventing an install recipe that nobody has verified end to end. check-sdk-extras.py: 2 problems -> 0, exit 0. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
release-train: develop -> staging
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fa542c6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-mainbranch (a mirror ofstaging), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
Docs-only changes to installation guidance; no runtime, auth, or data-handling code.
Overview
Documentation-only updates to
traceblocinstall instructions in the start-training guide and SDK tools page.Commented
pip install "tracebloc[tensorflow]..."examples are removed, and the[all]extra is described as pytorch + sklearn + lifelines + scikit-survival (not “every framework” / not TensorFlow). The SDK page adds a Note listing the real published extras, stating there is notensorflowextra, and warning that unknown pip extras only warn while still exiting 0—so a bad extra can look like a successful install until a framework import fails later.Reviewed by Cursor Bugbot for commit fa542c6. Bugbot is set up for automated code reviews on this repo. Configure here.