Repository navigation
🐛 fix(path): verify known implementations - #233
Merged
gaborbernat merged 2 commits intoNov 3, 2026
Merged
Conversation
The lookup accepted a PATH candidate named for PyPy even when it reported CPython. Check the reported implementation for known names while keeping unknown prefixes available as literal executable names. Fixes tox-dev#201
The mixed-case alias tests now use the current interpreter's free-threaded suffix. Without it, 3.15t rejects the alias on the threading flag before implementation matching. Resolve the test imports added on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_interpreter("pypy3.11")could return CPython whenPATHcontained a CPython executable with a PyPy filename. The old candidate filter let the filename bypass the implementation check. PATH discovery now checks the interpreter's reported implementation for known implementation names. Fixes #201.Named candidates skipped the implementation check
The direct-name path disabled the check, while the filename-pattern path enabled it only when the matched spelling was exactly lowercase
python.PythonInfo.satisfies()uses that flag to check the reported implementation. The new candidate filter sets the flag from the requested known implementation for both paths.Behavior changes
Explicit CPython, PyPy, and GraalPy specs reject candidates that report another implementation, regardless of the executable's name or letter case. Generic
pythonspecs and unknown prefixes remain available for literal executable-name lookup.Reported by Anthropic's OSS Scanner:
ANT-2026-Y51C67N2.