Skip to content

🐛 fix(validate-news): read the current PR labels - #35

Merged
gaborbernat merged 1 commit into
mainfrom
live-labels
Oct 27, 2026
Merged

gaborbernat merged 1 commit into
mainfrom
live-labels

Conversation

@gaborbernat

Copy link
Copy Markdown
Member

Re-running a failed Changelog run after adding skip news failed again. A re-run replays its original event, so the check judged the labels the PR had when that run started; on virtualenv #3463 the re-run also cancelled the newer run that the label had started, which would have passed. 🏷️

validate-news now asks the API for the PR's labels when it decides whether skip news waives the fragment, so every run, re-run or not, judges the labels the PR has now. Label changes still start a run on their own through the labeled and unlabeled triggers.

Callers need pull-requests: read on the job that runs the Action, since the job token cannot read PR labels without it.

@gaborbernat gaborbernat added the bug Something isn't working label Oct 27, 2026
@gaborbernat
gaborbernat merged commit e57b30b into main Oct 27, 2026
11 checks passed
gaborbernat added a commit to gaborbernat/bump-deps-index that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to gaborbernat/mdformat-hugo that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to gaborbernat/pypi-changes that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to pypa/pipx that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to pypa/virtualenv that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to pytest-dev/pytest-env that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to pytest-dev/pytest-print that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/action-pre-commit-uv that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/devpi-process that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/filelock that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/jetbrains-fish that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/pipdeptree that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/platformdirs that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/pre-commit-uv that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/pyproject-api that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/python-discovery that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/PyVenvManage that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/sphinx-argparse-cli that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/sphinx-autodoc-typehints that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/toml-fmt that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/tox that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/tox-gh that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/tox-ini-fmt that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/tox-uv that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/turbohtml that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
gaborbernat added a commit to tox-dev/xml-fmt that referenced this pull request Oct 27, 2026
Moves every
[`tox-dev/github-workflows`](https://github.com/tox-dev/github-workflows)
pin to
[6.2.1](https://github.com/tox-dev/github-workflows/releases/tag/6.2.1).
🏷️ The Changelog check now reads the pull request's labels from the API,
so re-running an older run after adding `skip news` passes instead of
judging the labels its original event carried
([#35](tox-dev/github-workflows#35)).

The news job gains `pull-requests: read`, which the job token needs to
read those labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant