Repository navigation
馃悰 fix: check locks with their own Nab, isolate tool installs - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from an adversarial review of 5.0.1.
A new Nab release would fail every committed lock. Nab writes its own version into
[tool.nab] nab-version, and check mode installed the newest cooled Nab, so from seven days after any Nab release every PR and tag run failed until the weekly refresh landed. Check mode now installs the Nab version the committedpylock.tomlrecords; refresh mode still takes the newest cooled release, andnab-git-commitkeeps its git install in both.The caller's uv configuration could change where gw's own tools come from. A
[tool.uv] index-url, auv.tomlorUV_INDEX_URLredirectedinstall_live_tools.sh, so a PR could swap the Nab that checks its own lock. The script now ignores repository config and index variables, ascooled_prek.shalready does.validate-newslet a PR deletepylock.tomlwhilenab.tomlstill configures it. The guard now coversnab.tomltoo.Also: the test fixtures lose the groups 5.0.0 removed, a plain
tox pinstalls release-creator and prek from thetestgroup instead of relying on a separate install, and the README names theworkflow_dispatchtaginput thatcheck-tagged-sourcereads.