fix(psycopg): check connection health on pool checkout - #2285
Open
RitiGrover wants to merge 1 commit into
Open
RitiGrover wants to merge 1 commit into
RitiGrover wants to merge 1 commit into
Conversation
Connections silently dropped by the network while idle (firewall/LB timeout, DB restart) were handed straight to callers, failing with psycopg.OperationalError: the connection is closed. Pass psycopg_pool's own check_connection callback so the pool validates and replaces dead connections on checkout. Fixes tortoise#2007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PsycopgClient.create_connectionbuilds the psycopg_pool without acheckcallback, sogetconn()never validates a connection before handing it out. A connection silently killed by the network (idle firewall/LB timeout, DB restart) sits in the pool looking fine until something tries to use it, then fails hard.Motivation and Context
Fixes #2007. Users see
psycopg.OperationalError: the connection is closedonin_transaction()after the app has been running a few days, with no automatic recovery.Passing
check=AsyncConnectionPool.check_connectionuses psycopg_pool''s own built-in liveness probe on checkout, so a dead connection gets replaced transparently instead of surfacing to the caller.How Has This Been Tested?
test_connection_params.py,test_password_factory.py, and the rest of the non-DB-dependent tests undertests/backends/) - all passruffandmypyclean on the changed filesChecklist