Conversation
Postgres truncates identifiers to 63 bytes, which breaks parsing field names from long JOIN aliases in execute_select. Record each related group's field names when the query is built and zip them positionally so long OneToOne and nested FK names work. Fixes tortoise#1902 Co-authored-by: MarkGus0 <MarkGus0@users.noreply.github.com>
5 tasks
Merging this PR will improve performance by 33.03%
Performance Changes
Tip Curious why performance improved? Comment Comparing |
Nested lookups re-selected the parent relation columns while _select_related_idx kept a single entry, so positional hydration mis-sliced rows and set phantom related objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Postgres truncates identifiers to 63 bytes. Tortoise select_related JOINs build aliases such as table__long_relation__nested.field and execute_select used to recover field names by splitting those aliases on a dot. After truncation this raises IndexError (the separator is gone) or hydrates the wrong attribute.
Related columns were already sliced by position via select_related_idx. This change records the ordered field names for each related group when the query is built and zips them with row values, so field identity no longer depends on untruncated aliases. SQLite and MySQL keep the same SELECT shape; only hydration mapping changes.
Motivation and Context
Fixes #1902
How Has This Been Tested?
Checklist: