Skip to content

Migration 26 | Reduce min number of cards for Featured services - #458

Open
chris-lawton wants to merge 1 commit into
migration-2026from
four-featured-services
Open

Migration 26 | Reduce min number of cards for Featured services#458
chris-lawton wants to merge 1 commit into
migration-2026from
four-featured-services

Conversation

@chris-lawton

Copy link
Copy Markdown
Member

Link to Ticket

Description of Changes Made

Allow min four cards in service area featured services block

How to Test

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@chris-lawton chris-lawton changed the title Reduce min number of cards for Featured services Migration 26 | Reduce min number of cards for Featured services Sep 3, 2026

@helenb helenb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the service area page. I notice that there is also a featured services block on the sector index page with a different maximum number - might be worth just double checking that one doesn't need to change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants