Conversation
What was broken The My Submissions tab replaced a completed Marathon Match provisional score with a dash while system tests were still running. Root cause The row hid the provisional score for every in-progress test status without distinguishing an in-progress provisional run from a later system run. What was changed The My Submissions row now keeps the completed provisional score visible when the current test process is system, matching the existing public submissions behavior. Any added/updated tests Added focused My Submissions row tests covering both an in-progress system run and an in-progress provisional run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The My Submissions tab replaced a completed Marathon Match provisional score with a dash while system tests were still running.
Root cause
The row hid the provisional score for every in-progress test status without distinguishing an in-progress provisional run from a later system run.
What was changed
The My Submissions row now keeps the completed provisional score visible when the current test process is system, matching the existing public submissions behavior.
Any added/updated tests
Added focused My Submissions row tests covering both an in-progress system run and an in-progress provisional run. The focused test, full test suite, lint, and production build pass.