Conversation
What was broken Challenge detail and listing responses counted multiple Design concepts from one member as a single submission, so the Community App displayed an incorrect submissions total. Root cause Challenge API recomputed both final and checkpoint counters with the submitting member ID as the distinct identity for every challenge track. What was changed Use the submission ID as the distinct counter identity for Design challenges while preserving member-based counting for all other tracks. Apply the rule to both checkpoint and non-checkpoint submissions. Any added/updated tests Added regression coverage for multiple final and checkpoint Design concepts from one member across challenge detail and listing responses. Preserved the existing Development-track deduplication coverage.
What was broken The challenge API schema described submissionsViewable as an additional prerequisite for Design winning-submission downloads. Root cause Swagger documentation still reflected the obsolete Design-specific authorization gate. What was changed Removed the obsolete submissionsViewable prerequisite from the winning-download metadata descriptions in create, update, patch, and response schemas. Any added/updated tests No tests were changed because this is a documentation-only contract correction; existing metadata validation tests continue to cover exact values and omission.
What was broken Manual phase changes published one shared email with raw timestamps for all challenge resources, without honoring each resource's phase-notification preference or member timezone. Root cause The manual phase update path built one common template payload and did not load recipient profile locations, so the timestamp and subject could not be personalized. What was changed Filter to opted-in resources and publish one external.action.email event per unique recipient. Resolve profile locations in bounded batches, default unresolved locations to UTC, format times as MMMM DD, YYYY HH:mm z, and add localized_time and phase_change while preserving the legacy template fields. Removed member profile response logging from the lookup used by this flow. Any added/updated tests Added phase service coverage for individual delivery, preference filtering, email deduplication, local and UTC timestamps, country fallback, open and closed payloads, and reopen wording.
What was broken The Challenge API hid assigned checkpoint winners until the entire challenge was completed, so the review app could not identify winners after Checkpoint Review. Root cause Winner response sanitization removed both final-placement and checkpoint winner data for every non-completed challenge. What was changed - Expose checkpoint winners for active challenges only after Checkpoint Review has opened and closed. - Continue hiding final-placement winners until challenge completion. - Document when checkpoint winners are returned. Any added/updated tests - Added detail and listing coverage for open and closed Checkpoint Review states. - Verified placement winners remain hidden while checkpoint winners become visible.
PM-5761: Count every design submission concept
PM-5754: update winning download metadata docs
PM-5763: Send localized phase notifications
PM-5775: expose active checkpoint winners
Test challenge flag PM-5802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5761
https://topcoder.atlassian.net/browse/PM-5754
https://topcoder.atlassian.net/browse/PM-5763
https://topcoder.atlassian.net/browse/PM-5775
https://topcoder.atlassian.net/browse/PM-5802