Repository navigation
Improve the encoding scheme of vint - #15
Merged
Merged
Conversation
tomtomwombat
force-pushed
the
tomtomwombat/vint-perf
branch
from
October 8, 2026 00:42
62563aa to
294a106
Compare
tomtomwombat
force-pushed
the
tomtomwombat/vint-perf
branch
from
October 8, 2026 05:47
294a106 to
ed8efab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR has two changes:
ColdStrings, we can read and compare the firstWIDTHbytes without parsing the vint. This is a fast path and works because strings are only stored on heap iff there are more thanWIDTHbytes. We don't readWIDTH + 2bytes, even though we could (accounting for at least 1 vint byte, plusWIDTH + 1or more UTF-8 bytes) because it's slower (probably because it requires more reads?).WIDTH + 2bytes from heap, and mask away junk UTF-8 bytes past the var-int's len.Benchmark:
as_str(ns/op)Stringcold_string::ColdStringcompact_str::CompactStringcompact_string::CompactStringsmallstr::SmallString<[u8; 8]>smartstring::alias::Stringsmol_str::SmolStrBenchmark:
eq(ns/op)Stringcold_string::ColdStringcompact_str::CompactStringcompact_string::CompactStringsmallstr::SmallString<[u8; 8]>smartstring::alias::Stringsmol_str::SmolStrBenchmark:
len(ns/op)Stringcold_string::ColdStringcompact_str::CompactStringcompact_string::CompactStringsmallstr::SmallString<[u8; 8]>smartstring::alias::Stringsmol_str::SmolStrBenchmark:
new(ns/op)Stringcold_string::ColdStringcompact_str::CompactStringcompact_string::CompactStringsmallstr::SmallString<[u8; 8]>smartstring::alias::Stringsmol_str::SmolStr