Repository navigation
use trailing/leading ones to get length of inlined strings - #14
Merged
Merged
Conversation
tomtomwombat
force-pushed
the
tomtomwombat/trailing
branch
from
October 5, 2026 02:30
0632f55 to
65ef8aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces old inline encoding. Trailing bytes of inline strings are
0b11111111, e.g. a len 3 string has 5 trailingu8::MAX. Then, len is calculated using leading/trailing ones:This is simpler than previously, because the start position of utf-8 bytes are always 0 and the new encoding naturally works with 8 inlined bytes. Also,
WORD_NUL_MAPis adjusted to(usize::MAX >> ALIGN_BITS * 2) << ALIGN_BITS;:TAG_MASK)inline_len(although never used)Inspired from @bonzini and https://github.com/bonzini/arcstring/blob/main/src/encoder.rs