Add server-side UploadCompletionListener and return UploadInfo from process() - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a server-side upload completion callback mechanism and updates
TusFileUploadService.process(...)to return the processedUploadInfo.Summary of Changes
UploadCompletionListenerFunctional Interface:@FunctionalInterface public interface UploadCompletionListenerwithvoid onUploadComplete(UploadInfo uploadInfo, TusFileUploadService tusFileUploadService).withUploadCompletionListener(UploadCompletionListener)andaddUploadCompletionListener(UploadCompletionListener)toTusFileUploadService.wasInProgress) and triggers listeners when transitioning to complete.service.getUploadedBytes(uploadInfo)orservice.deleteUpload(uploadInfo)without lock contention orUploadAlreadyLockedException.process()Return Value & Convenience Overloads:TusFileUploadService.process(...)now returns the created or updatedUploadInfo(ornullon errors /OPTIONS).TusFileUploadService.getUploadedBytes(UploadInfo)andTusFileUploadService.deleteUpload(UploadInfo)convenience methods.UploadCompletionListenerTest.java(8 unit tests).AbstractITTusFileUploadService.javaandAbstractITRufhProtocol.javacovering Tus PATCH,creation-with-upload, concatenation, and RUFH optimistic POST / PATCH appends across Disk, S3, and Azure Blob storage.README.mdwith configuration options, session upload ID association examples (Creation vs. Progress check pattern), listener usage, and single-request lifecycle timing notes.CHANGELOG.mdunder## [2.0.0].Verification
mvn clean install -q: ✅ PASSEDpython3 scripts/check-coverage.py --per-file-limit 90: ✅ PASSED (Diff coverage: 97.60%, all files > 90%)