Repository navigation
fix: inherit rest area POI names onto bare motorway_junction nodes - #4
Merged
Merged
Conversation
Rest area junction nodes in OSM typically have no ref or name — the name lives on the highway=rest_area way, not the motorway_junction node. The corridor builder filtered these out as "bare mapping artifacts," dropping hundreds of state rest areas from corridor_exits. Changes: - Load rest area POI names from exit_poi_candidates at startup - Enrich all_exit_nodes so sibling/nearby discovery also inherits names - Before the noref/noname filter in build_corridor_draft, inherit rest area names onto nameless exits - Apply same logic in the graph fallback corridor builder This recovers ~1,256 rest area exits (e.g., Jefferson County, Jackson County, Okaloosa County rest areas on I-10 FL) that were previously invisible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reforname— the name lives on thehighway=rest_areaway. The corridor builder filtered these as "bare mapping artifacts," dropping hundreds of state rest areas fromcorridor_exits.exit_poi_candidatesat startup and inherit them onto nameless exit nodesall_exit_nodesso sibling/nearby discovery also picks up rest area namesBuilds on PR #3 which fixed the derive.sql side (nameless POIs). This PR fixes the corridor builder side (nameless exits).
Test plan
cargo check -p openinterstate-derivepassesnode/1724808254) appears in corridor_exits for I-10🤖 Generated with Claude Code