feat: add Architecture.RegisterCallingConvention (Python parity)#32
Merged
Merged
Conversation
The C# binding declared BNRegisterCallingConvention but exposed no managed wrapper, so plugin authors defining custom architectures could not register a calling convention. Mirror Python Architecture.register_calling_convention (architecture.py:2593) with a direct pass-through on Architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes HIGH-severity parity gap #21:
BNRegisterCallingConventionwas declared but had no managed wrapper, so custom-architecture plugin authors could not register a calling convention. Mirrors PythonArchitecture.register_calling_convention(architecture.py:2593).Change
One pass-through method on
Architecture(Handle/BNArchitecture.cs), placed besideGetCallingConventionByName. The matchingSetDefaultCallingConvention/SetCdecl/… setters already existed.E2E test (harness repo)
ArchitectureRegisterCallingConventionTests.RegisterCallingConventionAddsConventionToArchitecture— registers an existing convention, asserts the architecture's convention list grows by one (the core registers verbatim, no de-dup) and the convention stays retrievable by name. Round-trips the wrapper. Full harness regression 50/50.