Repository navigation
Add an application environment resolved from APP_ENV through recognized aliases. - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplicationEnvironmentbacked enum with theLOCAL,TEST,DEVELOPMENT,STAGING, andPRODUCTIONcases, so a consumer asksisLocal()instead of comparingAPP_ENVto a raw string.ApplicationEnvironment::current(), which readsAPP_ENVthroughEnvironmentVariable::from, so the same resolution order and theHTTP_guard apply and a missing variable still raisesEnvironmentVariableMissing.ApplicationEnvironment::fromAlias(), matching aliases regardless of casing and of surrounding whitespace:localandlocalhost,testandtesting,development,dev, anddevelop,staging,stage,homolog, andhomologation,productionandprod.ApplicationEnvironmentUnrecognized, raised for a value no environment recognizes, with the accepted aliases in its message.isLocal(),isTest(),isDevelopment(),isStaging(), andisProduction()predicates, plusaliases().The existing API is unchanged.
Related issue
None.
Checklist
make reviewpasses.make testspasses.