fix: harden host-specific skill generation#4
Open
time-attack wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reconstructs three small, independently reviewed fixes from the rejected
wave-hostsbundle:review;/shiploadqa-onlyfrom the Codex generated-skill root instead of a Claude-only path;skill:checkhonor the primary host's configuredskipSkillsentries.The original 100-file wave was not merged or cherry-picked. New hosts, destructive migrations/installers, unsafe Gemini flags, auth changes, telemetry changes, and unrelated generated churn were excluded.
Test Coverage
bun run buildpasses.git diff --checkpasses.Live Evidence
Each accepted behavior used an immutable baseline plus separate candidate directories and HOME roots. The exact same production probe was run before and after across five isolated repositories:
hermes skills list.qa-onlylookup: 5 baseline failures → 5 candidate passes by executing the actual generated lookup command.skill:checkexclusion: 5 baseline failures → 5 candidate passes using the installed health command.All three
pr-test-envgates passed after the final code fingerprint.Pre-Landing Review
The complete 50-PR wave was reviewed against each original PR diff. Only garrytan#1054, garrytan#1430, and garrytan#1772 were accepted. The exhaustive local verdict records all accepted, partial, dropped, duplicate, already-on-main, and human-signoff decisions.
Design Review
No frontend files changed — design review skipped.
Remaining Limits
/shipoperation.Test plan
bun test test/host-config.test.ts test/gen-skill-docs.test.ts test/skill-validation.test.ts— 807 pass, 0 failbun run buildqa-onlyread