Move the log storage and Istio waypoint controllers into pkg/enterprise - #5278
Open
caseydavenport wants to merge 6 commits into
Open
Move the log storage and Istio waypoint controllers into pkg/enterprise#5278caseydavenport wants to merge 6 commits into
caseydavenport wants to merge 6 commits into
Conversation
A variant contributes its own controllers through the controller list on the controller options, which the manager setup iterates instead of naming them.
The Enterprise tree mirrors the core tree it came from, keeping controllers apart from the extension packages that share the directory.
Application layer, egress gateway, packet capture and OpenTelemetry collector, with the application layer and egress gateway render packages.
…nterprise The Typha and node TLS helpers move to the shared controller utilities, which is what lets the intrusion detection controller stop importing the installation controller.
Manager, non-cluster host, authentication and policy recommendation.
The log storage sub-controllers register as one entry, and the Istio waypoint controller registers on its own rather than being started by the Istio controller. The registration list moves out of pkg/enterprise so the controllers it names can keep importing that package from their tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fifth batch for CORE-13484, and the last of the controllers. The log storage sub-controllers and the Istio waypoint controller move under the Enterprise tree, leaving nothing in the core manager setup that only one variant runs.
Stacked on #5277. Review the last commit.
Related: CORE-13484
Release Note