Run E2E on every PR and gate releases on it - #85
Open
janithjay wants to merge 1 commit into
Open
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: janithjay <janithjayashan018@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
External PRs currently need a maintainer to manually add the
trigger-e2elabel before E2E ever runs. If that's missed, a PR can merge with a broken SDK and nobody finds out until the next nightly run (or later). Releases had no E2E coverage at all.release.ymlonly ran integration tests, so a broken SDK could ship as long asmainwas green on unit tests.Approach
pr-builder.yml: dropped the
trigger-e2elabel gate on the e2e job. It now runs on every PR. Removed the now-unused labeled event type from thepull_requesttrigger.release.yml: added a
test-e2ejob and madevalidatedepend on it. Everyrelease-*job already gates onneeds.validate.result == 'success', so this cascades correctly. An E2E failure skipsvalidate, which skips every SDK's publish step. Nothing ships if E2E fails.e2e-nightly.yml: fixed a comment that described the per-PR job as label-gated, which is no longer true.
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks