build(solidity): raise hardhat to 2.29, which Node 24 needs

[mswilkison]

Stacked on #4203. The last dependency step: hardhat 2.19.5 → 2.29.0 in
both packages.

smock capped this at 2.19.5. It is gone as of #4203, so the ceiling lifts —
and 2.26+ is what Node 24 requires. Below it, Hardhat's solc download fails on
Node 24 with HH502, because npm's undici and Node 24's bundled undici share a
global-dispatcher symbol.

Verified

Whole suite, both packages, both runtimes:

	Node 22	Node 24
ecdsa	673 / 44 pending / 0	673 / 44 / 0
random-beacon	955 / 0 pending / 0	955 / 0 / 0

Identical to the pre-bump results, so nothing regressed — and it is safe to
land before or after the Node bump in #4201, in either order.

The other thing 2.29 brings

	before	after
random-beacon	3m	23s
ecdsa	2m	31s

That is EDR, the Rust execution engine, backported into the 2.x line.

Two tests needed adjusting

challengeDkgResult has an inline gas check, and two tests deliberately
underfund the call to trigger it. hardhat 2.29 defaults to a newer hardfork,
where EIP-7623's intrinsic calldata floor is enforced before execution:

ProviderError: Transaction requires gas floor of 161720 but got limit of 100000

The node rejected the transaction outright, so the contract's own check never
ran — the tests had stopped testing the thing they name. The limits move to
just above each floor (100000 → 170000, 200000 → 220000), still far short
of what the call needs to complete, so both revert inside the contract as
intended.

The alternative was pinning the hardfork back to 2.19.5's default. Rejected:
mainnet is past it, and running the suite against an older EVM than production
is a worse trade than adjusting two gas limits.

After this

Node 22 → 24 in the five workflows, two Dockerfiles and two engines fields —
a small follow-up, and the reason the whole chain existed. #4201 already moved
those from 18 to 22; this makes 24 reachable for the first time.

Summary by CodeRabbit

• Chores

  • Updated the Hardhat development tooling to version 2.29.0 for the ECDSA and random beacon packages.

• Tests

  • Updated gas-limit scenarios to accurately validate insufficient-gas behavior under current transaction gas rules.
  • Clarified test coverage for contract-level gas checks.

[coderabbitai]

📝 Walkthrough

Walkthrough

Hardhat is upgraded from 2.19.5 to 2.29.0 in two Solidity packages. Two challengeDkgResult insufficient-gas tests increase transaction gas limits and clarify intrinsic calldata floor behavior.

Changes

Hardhat gas-floor compatibility

Layer / File(s)	Summary
Upgrade Hardhat development dependencies solidity/ecdsa/package.json, solidity/random-beacon/package.json	Updates the Hardhat development dependency from 2.19.5 to 2.29.0.
Adjust challengeDkgResult gas-limit tests solidity/ecdsa/test/WalletRegistry.CustomErrors.test.ts, solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts	Raises test transaction gas limits and documents the distinction between Hardhat’s intrinsic calldata floor and contract execution gas checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• Issue 4209: The Hardhat 2.29.0 upgrade is identified as a prerequisite for the planned Hardhat 3 migration in these Solidity packages.

Suggested reviewers: lionakhnazarov, piotr-roslaniec

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: upgrading Hardhat to 2.29 to support Node 24.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/solidity-hardhat-2.29-node-24

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[piotr-roslaniec]

Self-approve as repo admin. hardhat 2.19.5 -> 2.29.0 in both packages. 6 files, 664 +/- 2046. yarn.lock updates remove @chainsafe/* (replaced by @ethereumjs/*). Two test gas-limit adjustments (100000->170000, 200000->220000) explained in-line with EIP-7623 floor reasoning.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts`:
- Around line 3018-3026: Update the comment above the challengeDkgResult call in
the gas-limit test to state that gasLimit 220000 clears Hardhat’s pre-execution
calldata floor and exercises the contract-level gas check; remove language
implying the test asserts rejection below that floor.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bb7817c-8f09-4bed-92fd-6b3fc5280a87

📥 Commits

Reviewing files that changed from the base of the PR and between f45317c and fc611dd.

⛔ Files ignored due to path filters (2)

• solidity/ecdsa/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
• solidity/random-beacon/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (4)

• solidity/ecdsa/package.json
• solidity/ecdsa/test/WalletRegistry.CustomErrors.test.ts
• solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts
• solidity/random-beacon/package.json

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== locate file =="
fd -a 'WalletRegistry.WalletCreation.test.ts' . || true

echo "== relevant lines =="
FILE="$(fd 'WalletRegistry.WalletCreation.test.ts' . | head -n 1)"
if [ -n "${FILE:-}" ]; then
  wc -l "$FILE"
  sed -n '2980,3055p' "$FILE" | cat -n | sed 's/^/  /'
fi

echo "== nearby expect assertions =="
rg -n "challengeDkgResult|gasLimit: 220000|EIP-7623|intrinsic calldata floor|below it|contract's own gas check" "$FILE" || true

echo "== repo version/config hints =="
for f in package.json pnpm-lock.yaml yarn.lock package-lock.json hardhat.config.* tsconfig.json; do
  [ -f "$f" ] && printf '\n-- %s --\n' "$f" && sed -n '1,220p' "$f" | rg -n '"hardhat"|"hardhat-ethers"|2\.29|hardhat-ethers|hardhat-verify|gasReporter|gasLimit' -C 2 || true
done

Repository: threshold-network/keep-core

Length of output: 6585

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== hardhat deps across tracked files =="
rg -n '"hardhat"|"hardhat-ethers"|hardhat-version|gasLimit' --glob '!node_modules' --glob '!dist' --glob '!build' . | head -n 200 || true

echo "== package manifests =="
git ls-files '*package.json' | while read -r f; do
  echo "-- $f --"
  sed -n '1,240p' "$f" | jq -r '
    ["dependencies","devDependencies","peerDependencies"][] // empty
    as $section
    | ("[" + $section + "]: " + (.[$section] | tostring))
  ' 2>/dev/null | rg "hardhat|hardhat-ethers" || true
done

echo "== hardhat config gas settings =="
git ls-files 'hardhat.config.*' | while read -r f; do
  echo "-- $f --"
  sed -n '1,260p' "$f" | rg -n "gasLimit|hardhat|evmVersion|fork|mempool|gasMultiplier|gasPrice|maxFee|gas" -C 3 || true
done

Repository: threshold-network/keep-core

Length of output: 50384

---

🌐 Web query:

Hardhat 2.29 EIP-7623 intrinsic calldata floor gasMinimum documentation

💡 Result:

As of July 27, 2026, Hardhat v2.29.0 does not contain specific implementation logic or documentation regarding the intrinsic calldata floor gas requirement introduced by EIP-7623 [1][2]. The v2.29.0 release was a minor update focused on Mocha compatibility and TypeScript initialization [1]. EIP-7623: Increase calldata cost is an Ethereum standard that mandates a change in how transaction gas is calculated, specifically by introducing a minimum gas floor for data-heavy transactions [3][4]. Under this EIP, transactions that do not exceed a certain threshold of gas spent on EVM operations relative to gas spent on calldata are subject to an increased calldata cost (10/40 gas per byte) [3][4]. This ensures that data-heavy transactions contribute more appropriately to the network's gas usage, effectively reducing the maximum block size [3][4]. While node software and core development libraries (such as Geth) have moved to implement this logic [5], Hardhat's core package (v2.29.0) does not explicitly detail support for this intrinsic gas floor in its release notes or documentation [1][6][7]. Users relying on Hardhat for testing environments that require EIP-7623 compliance should monitor ongoing updates to Hardhat's Ethereum Development Runtime (EDR) or subsequent Hardhat versions, as EIP support in Hardhat is typically rolled out through these components [6][7][8].

Citations:

• 1: https://newreleases.io/project/github/NomicFoundation/hardhat/release/hardhat@2.29.0
• 2: chore(deps-dev): bump hardhat from 2.28.6 to 2.29.0 RigoBlock/v3-contracts#936
• 3: https://eips.ethereum.org/EIPS/eip-7623
• 4: https://raw.githubusercontent.com/ethereum/EIPs/master/EIPS/eip-7623.md
• 5: covalenthq/bsp-geth@0e1a19d
• 6: https://github.com/NomicFoundation/hardhat/releases
• 7: https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat/CHANGELOG.md
• 8: Support gas snapshots for Solidity tests NomicFoundation/hardhat#7769

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== tracked package manifests =="
git ls-files '*package.json' | sed -n '1,120p'

echo "== hardhat dependency lines in tracked manifests only =="
git ls-files '*package.json' \
  | xargs -r rg -n '"hardhat"|"hardhat-ethers"|`@nomicfoundation/hardhat-network`'| head -n 200 || true

echo "== package-manager/config lock summary =="
for f in package-lock.json pnpm-lock.yaml yarn.lock bun.lockb bun.lock README.md; do
  [ -e "$f" ] && printf '\n-- %s --\n' "$f" && sed -n '1,180p' "$f" | rg -n 'hardhat|hardhat-ethers|`@nomicfoundation/hardhat-network`|lockfileVersion|packageManager' -C 2 || true
done

echo "== test gas-limit comments context nearby =="
sed -n '3008,3032p' solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts | cat -n

Repository: threshold-network/keep-core

Length of output: 1909

---

Clarify which gas-failure path this test covers.

gasLimit: 220000 clears the pre-execution gas minimum, so this test is meant to exercise the contract-level challengeDkgResult gas check, not the Hardhat rejection for transactions below that minimum. Update the comment to avoid describing the below-floor rejection as the behavior under test.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts` around lines 3018
- 3026, Update the comment above the challengeDkgResult call in the gas-limit
test to state that gasLimit 220000 clears Hardhat’s pre-execution calldata floor
and exercises the contract-level gas check; remove language implying the test
asserts rejection below that floor.