Skip to content

FIX: Download issues with text and audio - #174

Open
connorclancydev wants to merge 2 commits into
thoth-tech:mainfrom
connorclancydev:BugFix/downloadsError
Open

connorclancydev wants to merge 2 commits into
thoth-tech:mainfrom
connorclancydev:BugFix/downloadsError

Conversation

@connorclancydev

Copy link
Copy Markdown

fixes the errors with test audio and text that stop the downloads from working properly by updating missing links

Description

There was a report that audio, text and bitmap downloads were not functioning properly, this PR solves all those issues and makes the MSYS match the WSL by fixing broken hyperlinks and adjusting the code to suit the new hyperlinks, originally errors would run in the tests for audio, text and windows now the only warning is the intentional warnings that are there for testing purposes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

so to test this you have to install a environment for WSL and MSYS preferably to test both but either should work. Then you will proceed to open the test application in terminal and select the following tests 1 audio, 13 text and 15 windows. to see they work all should work without throwing any errors that arent intentional. errors that are intentional have a message before them saying they are intentional. If testing both WSL and MSYS make sure that you install individual splashkits for each

Testing Checklist

  • Tested with sktest
  • Tested with skunit_tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

fixes the errors with test audio and text that stop the downloads from working properly by updating missing links

@rory-cd rory-cd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, it's an important fix to address.

I tested this in MSYS2:

  • test_audio: The new music file now downloads without issue
  • test_text: The new font is missing - (22/09/2026) WARNING -> Unable to download file from https://github.com/google/fonts/raw/master/ofl/ brawler/Brawler-Regular.ttf got status 404 [raised in web_client.cpp:90]. I visited that URL in a browser and got a 404 error. I would suggest replacing it with this one: https://github.com/google/fonts/blob/main/ofl/brawler/Brawler-Regular.ttf

Changes requested:

Turns out one of the new links implemented has already broken fix is a new link
@connorclancydev

Copy link
Copy Markdown
Author

New link has been implemented, thank you for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants